Optimize needNoSuchMethodHandling computation

pkg/compiler/lib/src/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 import '../common.dart';
 import '../common/resolution.dart' show Resolution;
 import '../compiler.dart' show Compiler;
 import '../constants/constructors.dart';
@@ skipping 1537 matching lines @@
   /// Returns `true` if this class has a @proxy annotation.
   bool get isProxy;
 
   /// Returns `true` if the class hierarchy for this class contains errors.
   bool get hasIncompleteHierarchy;
 
   void addBackendMember(Element element);
   void reverseBackendMembers();
 
   Element lookupMember(String memberName);
-  Element lookupByName(Name memberName);
+
+  /// Looks up a class instance member declared or inherited in this class
+  /// using [memberName] to match the (private) name and getter/setter property.
+  ///
+  /// If [stopAtSuperclass], no member from [stopAtSuperclass] or its

[Siggi Cherem (dart-lang), 2016/10/17 19:30:33]

If [stopAtSuperclass]... is specified?

ALternatively, "this recursively visits superclasses until the member is found
or [stopAt] is reached"?

[Johnni Winther, 2016/10/18 08:13:51]

Done.

+  /// superclasses will be returned.
+  Element lookupByName(Name memberName, {ClassElement stopAtSuperclass});

[Siggi Cherem (dart-lang), 2016/10/17 19:30:33]

nit: rename to just stopAt?

[Johnni Winther, 2016/10/18 08:13:51]

Done.

   Element lookupSuperByName(Name memberName);
 
   Element lookupLocalMember(String memberName);
   Element lookupBackendMember(String memberName);
   Element lookupSuperMember(String memberName);
 
   Element lookupSuperMemberInLibrary(String memberName, LibraryElement library);
 
   // TODO(johnniwinther): Clean up semantics. Can the default constructor take
   // optional arguments? Must it be resolved?
@@ skipping 343 matching lines @@
   /// by a field.
   bool get isDeclaredByField;
 
   /// Returns `true` if this member is abstract.
   bool get isAbstract;
 
   /// If abstract, [implementation] points to the overridden concrete member,
   /// if any. Otherwise [implementation] points to the member itself.
   Member get implementation;
 }