Simplify should-eager-compile handling

src/ast/scopes.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/scopes.h"
 
 #include <set>
 
 #include "src/accessors.h"
 #include "src/ast/ast.h"
@@ skipping 292 matching lines @@
 
   is_declaration_scope_ = false;
 }
 
 bool Scope::HasSimpleParameters() {
   DeclarationScope* scope = GetClosureScope();
   return !scope->is_function_scope() || scope->has_simple_parameters();
 }
 
 bool DeclarationScope::ShouldEagerCompile() const {
-  if (!AllowsLazyCompilation()) return true;
-  return !is_lazily_parsed_ && should_eager_compile_;
+  return force_eager_compilation_ || should_eager_compile_;
 }
 
 void DeclarationScope::set_should_eager_compile() {
-  should_eager_compile_ = true;
+  should_eager_compile_ = !is_lazily_parsed_;

[jochen (gone - plz use gerrit), 2016/10/17 11:23:37]

when is is_lazily_parsed_ true here?

[Toon Verwaest, 2016/10/17 11:28:35]

If we preparsed the function for example. E.g.,:

!function(){}() at the toplevel will try to set_should_eager_compile due to the
() at the end, but we will have preparsed the function, so we can't make it be
eagerly compiled. In the future, hopefully it will be true as well for all inner
function of a ParseFunction job, since we will have preparsed them all already,
and will just skip over it in O(1).

 }
 
 void DeclarationScope::set_asm_module() {
   asm_module_ = true;
   // Mark any existing inner function scopes as asm function scopes.
   for (Scope* inner = inner_scope_; inner != nullptr; inner = inner->sibling_) {
     if (inner->is_function_scope()) {
       inner->AsDeclarationScope()->set_asm_function();
     }
   }
@@ skipping 1640 matching lines @@
   Variable* function =
       is_function_scope() ? AsDeclarationScope()->function_var() : nullptr;
   bool is_function_var_in_context =
       function != nullptr && function->IsContextSlot();
   return num_heap_slots() - Context::MIN_CONTEXT_SLOTS -
          (is_function_var_in_context ? 1 : 0);
 }
 
 }  // namespace internal
 }  // namespace v8