third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp - Issue 2428513004: [SPv2] Create effect nodes for CSS filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

Issue 2428513004: [SPv2] Create effect nodes for CSS filter (Closed)

Patch Set: address pdr's comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp » ('j') | third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

index 622e0e5692a6b9ae6baf340cc3a45fc7f3559e62..ded4b9d1d6d6d7928f4b83f25f5497972420439f 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

@@ -47,7 +47,9 @@ class GeometryMapperTest : public ::testing::Test {

rootClipNode = ClipPaintPropertyNode::create(

nullptr, rootTransformNode,

FloatRoundedRect(LayoutRect::infiniteIntRect()));

- rootEffectNode = EffectPaintPropertyNode::create(nullptr, 1.0);

+ rootEffectNode = EffectPaintPropertyNode::create(

+ nullptr, rootTransformNode, rootClipNode, CompositorFilterOperations(),

+ 1.0);

rootScrollNode = ScrollPaintPropertyNode::create(

nullptr, rootTransformNode, IntSize(), IntSize(), false, false);

geometryMapper = wrapUnique(new GeometryMapper());