[SPv2] Create effect nodes for CSS filter

third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintChunker.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::ElementsAre;
 
 namespace blink {
 namespace {
 
 // TODO(crbug.com/629946): The tests fail mysteriously on some Windows debug
 // bots.
 #if defined(NDEBUG) || !OS(WIN)
 
-static PaintChunkProperties rootPaintChunkProperties() {
+TransformPaintPropertyNode* dummyRootTransform() {

[pdr., 2016/10/22 03:58:37]

Potential followup: WDYT of adding a superclass that all spv2 tests inherit
from, and defining these once there? We could also add helpers such as
createFilterEffectNode, createOpacityEffectNode, etc, to avoid needing to update
all tests when adding new effect subtypes.

[trchen, 2016/10/24 21:53:20]

I'm thinking to move the static root nodes to
Source/platform/graphics/paint/*PaintPropertyNode.cpp
Is there a reason why that'd be a bad idea?

I think adding the helper function is a good idea.

+  DEFINE_STATIC_REF(TransformPaintPropertyNode, rootTransform,
+                    (TransformPaintPropertyNode::create(
+                        nullptr, TransformationMatrix(), FloatPoint3D())));
+  return rootTransform;
+}
+
+ClipPaintPropertyNode* dummyRootClip() {
+  DEFINE_STATIC_REF(ClipPaintPropertyNode, rootClip,
+                    (ClipPaintPropertyNode::create(
+                        nullptr, dummyRootTransform(),
+                        FloatRoundedRect(LayoutRect::infiniteIntRect()))));
+  return rootClip;
+}
+
+EffectPaintPropertyNode* dummyRootEffect() {
+  DEFINE_STATIC_REF(EffectPaintPropertyNode, rootEffect,
+                    (EffectPaintPropertyNode::create(
+                        nullptr, dummyRootTransform(), dummyRootClip(),
+                        CompositorFilterOperations(), 1.0)));
+  return rootEffect;
+}
+
+PaintChunkProperties rootPaintChunkProperties() {
   return PaintChunkProperties();
 }
 
 class PaintChunkerTest : public testing::Test {
  protected:
   void SetUp() override {
     RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true);
   }
 
   void TearDown() override { m_featuresBackup.restore(); }
@@ skipping 109 matching lines @@
 
   PaintChunkProperties simpleTransform;
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 0, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   PaintChunkProperties simpleTransformAndEffect;
   simpleTransformAndEffect.transform = simpleTransform.transform;
-  simpleTransformAndEffect.effect =
-      EffectPaintPropertyNode::create(nullptr, 0.5f);
+  simpleTransformAndEffect.effect = EffectPaintPropertyNode::create(
+      dummyRootEffect(), dummyRootTransform(), dummyRootClip(),
+      CompositorFilterOperations(), 0.5f);
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffect);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   PaintChunkProperties simpleTransformAndEffectWithUpdatedTransform;
   simpleTransformAndEffectWithUpdatedTransform.transform =
       TransformPaintPropertyNode::create(nullptr,
                                          TransformationMatrix(1, 1, 0, 0, 0, 0),
                                          FloatPoint3D(9, 8, 7));
   simpleTransformAndEffectWithUpdatedTransform.effect =
       EffectPaintPropertyNode::create(
-          nullptr, simpleTransformAndEffect.effect->opacity());
+          dummyRootEffect(), dummyRootTransform(), dummyRootClip(),
+          CompositorFilterOperations(),
+          simpleTransformAndEffect.effect->opacity());
   chunker.updateCurrentPaintChunkProperties(
       nullptr, simpleTransformAndEffectWithUpdatedTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   // Test that going back to a previous chunk property still creates a new
   // chunk.
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffect);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
@@ skipping 166 matching lines @@
                   PaintChunk(2, 4, nullptr, simpleTransform),
                   PaintChunk(4, 5, nullptr, simpleTransform),
                   PaintChunk(5, 6, nullptr, simpleTransform),
                   PaintChunk(6, 7, nullptr, rootPaintChunkProperties())));
 }
 
 #endif
 
 }  // namespace
 }  // namespace blink