Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2428493003: [heap] Reland move slot filtering logic into sweeper. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland move slot filtering logic into sweeper. BUG=chromium:648568 Committed: https://crrev.com/60cb6013d40c4c202b9389dc4dc2b0be07b4b267 Cr-Commit-Position: refs/heads/master@{#40393}

Patch Set 1 #

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -67 lines) Patch
M src/base/atomic-utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 8 chunks +29 lines, -10 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/heap/slot-set.h View 4 chunks +32 lines, -17 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 2 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Hannes Payer (out of office)
4 years, 2 months ago (2016-10-18 05:47:51 UTC) #6
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-18 07:01:47 UTC) #7
ulan
lgtm
4 years, 2 months ago (2016-10-18 07:22:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428493003/20001
4 years, 2 months ago (2016-10-18 09:40:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 10:06:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 10:07:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60cb6013d40c4c202b9389dc4dc2b0be07b4b267
Cr-Commit-Position: refs/heads/master@{#40393}

Powered by Google App Engine
This is Rietveld 408576698