Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2428493002: [turbofan] Eliminate redundant ChangeTaggedSignedToInt32. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate redundant ChangeTaggedSignedToInt32. Apply the same strength reduction to the ChangeTaggedSignedToInt32 operator that we already have for ChangeTaggedToInt32. R=epertoso@chromium.org Committed: https://crrev.com/4386dfeee0403d3348df9ccca2be596810fccc92 Cr-Commit-Position: refs/heads/master@{#40352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 09:31:39 UTC) #1
Benedikt Meurer
Hey Enrico, Here's a very simple one-liner. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-10-17 09:32:20 UTC) #4
epertoso
lgtm
4 years, 2 months ago (2016-10-17 09:53:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428493002/1
4 years, 2 months ago (2016-10-17 10:07:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 10:14:44 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:15:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4386dfeee0403d3348df9ccca2be596810fccc92
Cr-Commit-Position: refs/heads/master@{#40352}

Powered by Google App Engine
This is Rietveld 408576698