[inspector] align console implementation with spec

src/inspector/inspected-context.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/inspected-context.h"
 
 #include "src/inspector/injected-script.h"
 #include "src/inspector/string-util.h"
 #include "src/inspector/v8-console.h"
 #include "src/inspector/v8-inspector-impl.h"
@@ skipping 30 matching lines @@
       m_humanReadableName(toString16(info.humanReadableName)),
       m_auxData(toString16(info.auxData)),
       m_reported(false) {
   m_context.SetWeak(&m_context, &clearContext,
                     v8::WeakCallbackType::kParameter);
 
   v8::Isolate* isolate = m_inspector->isolate();
   v8::Local<v8::Object> global = info.context->Global();
   v8::Local<v8::Object> console =
       V8Console::createConsole(this, info.hasMemoryOnConsole);
+  v8::PropertyDescriptor descriptor(console, /* writable */ true);
+  descriptor.set_enumerable(false);
+  descriptor.set_configurable(true);
   if (!global
-           ->Set(info.context, toV8StringInternalized(isolate, "console"),
-                 console)
+           ->DefineProperty(info.context,

[dgozman, 2016/10/19 00:19:53]

What is this formatting?

[kozy, 2016/10/19 00:54:36]

Done.

+                            toV8StringInternalized(isolate, "console"),
+                            descriptor)
            .FromMaybe(false))
     return;
   m_console.Reset(isolate, console);
   m_console.SetWeak();
 }
 
 InspectedContext::~InspectedContext() {
   if (!m_console.IsEmpty()) {
     v8::HandleScope scope(isolate());
     V8Console::clearInspectedContextIfNeeded(context(),
@@ skipping 10 matching lines @@
 }
 
 void InspectedContext::createInjectedScript() {
   DCHECK(!m_injectedScript);
   m_injectedScript = InjectedScript::create(this);
 }
 
 void InspectedContext::discardInjectedScript() { m_injectedScript.reset(); }
 
 }  // namespace v8_inspector