Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2428473002: [ic] Cache weak cells containing prototypes in respective PrototypeInfo objects. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Cache weak cells containing prototypes in respective PrototypeInfo objects. BUG= Committed: https://crrev.com/7078c31dc616c8b9b50ae381da07aa9c48bd3b3c Cr-Commit-Position: refs/heads/master@{#40358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -32 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-17 09:24:52 UTC) #5
Jakob Kummerow
Cool, thanks! LGTM.
4 years, 2 months ago (2016-10-17 11:33:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428473002/20001
4 years, 2 months ago (2016-10-17 11:41:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-17 11:44:41 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 11:45:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7078c31dc616c8b9b50ae381da07aa9c48bd3b3c
Cr-Commit-Position: refs/heads/master@{#40358}

Powered by Google App Engine
This is Rietveld 408576698