Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2428463002:
[serializer] add test case for unknown external references. (Closed)
Description[serializer] add test case for unknown external references.
Unknown external references must trigger assertion failure.
Committed: https://crrev.com/0655c45986eedfc2948d3b47ccac9ed57533e524
Cr-Commit-Position: refs/heads/master@{#40391}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix 2 #
Messages
Total messages: 27 (18 generated)
yangguo@chromium.org changed reviewers: + jochen@chromium.org
Please take a look.
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [serializer] add test case for unknown external references. Unknown external references must trigger DCHECK failure or null deref. ========== to ========== [serializer] add test case for unknown external references. Unknown external references must trigger assertion failure. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [serializer] add test case for unknown external references. Unknown external references must trigger assertion failure. ========== to ========== [serializer] add test case for unknown external references. Unknown external references must trigger assertion failure. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [serializer] add test case for unknown external references. Unknown external references must trigger assertion failure. ========== to ========== [serializer] add test case for unknown external references. Unknown external references must trigger assertion failure. Committed: https://crrev.com/0655c45986eedfc2948d3b47ccac9ed57533e524 Cr-Commit-Position: refs/heads/master@{#40391} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0655c45986eedfc2948d3b47ccac9ed57533e524 Cr-Commit-Position: refs/heads/master@{#40391}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2429723005/ by machenbach@chromium.org. The reason for reverting is: Blocks roll: https://codereview.chromium.org/2428853002/.
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
Please add failing chromium bots on reland in CQ, e.g.: android_compile_dbg
Message was sent while issue was closed.
Bonus points: Find out why our android bot is not catching this O_O - guess we need an android debug compile bot?
Message was sent while issue was closed.
ok - clicked too fast. We did catch it - just not in CQ :/ Will stop the revert and backmerge the fix instead. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
