Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/content_settings/core/browser/content_settings_pref_provider.cc

Issue 2428433002: Delete fullscreen/mouselock pref data. (Closed)
Patch Set: Fix test by avoiding JS update calls. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_pref_provider.cc
diff --git a/components/content_settings/core/browser/content_settings_pref_provider.cc b/components/content_settings/core/browser/content_settings_pref_provider.cc
index 8d451633e2c74e43f097bb7f6c52349dfea9e8e3..fdb6c23a72fd2da75bde3eea37229cc5a41156e0 100644
--- a/components/content_settings/core/browser/content_settings_pref_provider.cc
+++ b/components/content_settings/core/browser/content_settings_pref_provider.cc
@@ -33,6 +33,18 @@
namespace content_settings {
+namespace {
+
+// These settings are no longer used, and should be deleted on profile startup.
+// NOTE: Do not use the CONTENT_SETTINGS_TYPE_* constants, as these will soon be
+// deleted.
+const char kObsoleteFullscreenExceptionsPref[] =
+ "profile.content_settings.exceptions.fullscreen";
+const char kObsoleteMouseLockExceptionsPref[] =
+ "profile.content_settings.exceptions.mouselock";
+
+} // namespace
+
// ////////////////////////////////////////////////////////////////////////////
// PrefProvider:
//
@@ -67,6 +79,8 @@ PrefProvider::PrefProvider(PrefService* prefs, bool incognito)
return;
}
+ DiscardObsoletePreferences();
+
pref_change_registrar_.Init(prefs_);
WebsiteSettingsRegistry* website_settings =
@@ -187,4 +201,9 @@ void PrefProvider::Notify(
resource_identifier);
}
+void PrefProvider::DiscardObsoletePreferences() {
+ prefs_->ClearPref(kObsoleteFullscreenExceptionsPref);
+ prefs_->ClearPref(kObsoleteMouseLockExceptionsPref);
+}
+
} // namespace content_settings

Powered by Google App Engine
This is Rietveld 408576698