Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler.cc

Issue 2428433002: Delete fullscreen/mouselock pref data. (Closed)
Patch Set: Fix test by avoiding JS update calls. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/site_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.cc b/chrome/browser/ui/webui/settings/site_settings_handler.cc
index 160a7934fb6162d8caed0d5c8de8bb64e208ba7d..d4b3dd9171ace60011d5e39665c01e91be96a930 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler.cc
@@ -224,6 +224,12 @@ void SiteSettingsHandler::OnContentSettingChanged(
if (!site_settings::HasRegisteredGroupName(content_type))
return;
+ // These content types are deprecated and should not trigger a UI update.
Matt Giuca 2016/10/26 04:18:24 I wish I didn't have to do this (it isn't strictly
stevenjb 2016/10/26 19:31:00 Could you add a TODO with a bug link? Generally mo
Matt Giuca 2016/10/26 23:26:47 Done.
+ if (content_type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
+ content_type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
+ return;
+ }
+
if (primary_pattern.ToString().empty()) {
CallJavascriptFunction(
"cr.webUIListenerCallback",

Powered by Google App Engine
This is Rietveld 408576698