Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: chrome/browser/content_settings/content_settings_default_provider_unittest.cc

Issue 2428433002: Delete fullscreen/mouselock pref data. (Closed)
Patch Set: Fix test by avoiding JS update calls. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_default_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_default_provider_unittest.cc b/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
index 8824d742e6bb4f47f23145c2a66f517713564309..716aba2c37d33189ce3298051732caa111a443fa 100644
--- a/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
@@ -152,6 +152,32 @@ TEST_F(DefaultProviderTest, ObservePref) {
std::string(), false));
}
+// Tests that fullscreen and mouselock content settings are cleared.
+TEST_F(DefaultProviderTest, DiscardObsoletePreferences) {
+ static const char kFullscreenPrefPath[] =
+ "profile.default_content_setting_values.fullscreen";
+ static const char kMouselockPrefPath[] =
+ "profile.default_content_setting_values.mouselock";
+ static const char kGeolocationPrefPath[] =
+ "profile.default_content_setting_values.geolocation";
+
+ PrefService* prefs = profile_.GetPrefs();
+ // Set some pref data.
+ prefs->SetInteger(kFullscreenPrefPath, CONTENT_SETTING_BLOCK);
+ prefs->SetInteger(kMouselockPrefPath, CONTENT_SETTING_ALLOW);
+ prefs->SetInteger(kGeolocationPrefPath, CONTENT_SETTING_BLOCK);
+
+ // Instantiate a new DefaultProvider; can't use |provider_| because we want to
+ // test the constructor's behavior after setting the above.
+ DefaultProvider provider(prefs, false);
+
+ // Check that fullscreen and mouselock have been deleted.
+ EXPECT_FALSE(prefs->HasPrefPath(kFullscreenPrefPath));
+ EXPECT_FALSE(prefs->HasPrefPath(kMouselockPrefPath));
+ EXPECT_TRUE(prefs->HasPrefPath(kGeolocationPrefPath));
+ EXPECT_EQ(CONTENT_SETTING_BLOCK, prefs->GetInteger(kGeolocationPrefPath));
+}
+
TEST_F(DefaultProviderTest, OffTheRecord) {
DefaultProvider otr_provider(profile_.GetPrefs(), true /* incognito */);

Powered by Google App Engine
This is Rietveld 408576698