Index: git_cl.py |
diff --git a/git_cl.py b/git_cl.py |
index c78207bdc9ee4f1ab1541ec1ca74238d8621b377..1726e75ef78cdea95ea52c4119ece6ff6432d8aa 100755 |
--- a/git_cl.py |
+++ b/git_cl.py |
@@ -390,7 +390,7 @@ def _trigger_try_jobs(auth_config, changelist, buckets, options, |
'patch_project': project, |
'patch_storage': 'rietveld', |
'patchset': patchset, |
- 'reason': options.name, |
+ 'reason': options.reason, |
'rietveld': codereview_url, |
}, |
} |
@@ -4768,9 +4768,9 @@ def CMDtry(parser, args): |
'json if decodable, or as string otherwise. ' |
'NOTE: using this may make your try job not usable for CQ, ' |
'which will then schedule another try job with default properties') |
- # TODO(tandrii): if this even used? |
qyearsley
2016/10/22 19:14:29
It's used for the "reason" string when triggering
tandrii(chromium)
2016/10/23 15:25:52
not necessary, ignored by CQ (though CQ sets it to
|
group.add_option( |
- '-n', '--name', help='Try job name; default to current branch name') |
+ '--reason', |
+ help='Try job "reason" string; defaults to current branch name') |
tandrii(chromium)
2016/10/23 15:25:52
i like this renaming, but please you remove defaul
qyearsley
2016/10/25 17:32:13
Do you mean let's only add it to try job propertie
tandrii(chromium)
2016/10/25 17:56:30
yes, PS#2 is exactly what I asked for :)
|
group.add_option( |
'--buildbucket-host', default='cr-buildbucket.appspot.com', |
help='Host of buildbucket. The default host is %default.') |
@@ -4801,8 +4801,8 @@ def CMDtry(parser, args): |
if error_message: |
parser.error('Can\'t trigger try jobs: %s') |
- if not options.name: |
- options.name = cl.GetBranch() |
+ if not options.reason: |
tandrii(chromium)
2016/10/23 15:25:52
that is, let's get rid of these two lines.
|
+ options.reason = cl.GetBranch() |
if options.bucket and options.master: |
parser.error('Only one of --bucket and --master may be used.') |