[Chromecast] Add input support.

chromecast/browser/cast_window_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROMECAST_BROWSER_CAST_WINDOW_MANAGER_H_
+#define CHROMECAST_BROWSER_CAST_WINDOW_MANAGER_H_
+
+#include "base/macros.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace chromecast {
+namespace shell {
+
+class CastWindowManager {

[derekjchow1, 2016/10/24 22:43:09]

Please add documentation for this class. What is it's purpose? What does the
lifetime for this class look like? Should only one instance of this class exist
per cast_shell?

[halliwell, 2016/10/25 01:43:09]

I'm slightly sceptical about this interface:
* StartWindowManager seems to get called implicitly from AddWebContents, so it's
not clear that it needs to be part of public interface
* 'window manager' is an existing concept (both generally and in Chromium), but
this doesn't really seem to match that. Are there plans for extending the
interface?
* Why do you add WebContents to it?  Shouldn't you add a window?

I would recommend syncing up with alokp on what the future of window management
and display may look like under mojo, and figure out how this would fit into it.

+ public:
+  CastWindowManager();
+
+  virtual ~CastWindowManager();
+
+  virtual void StartWindowManager();

[derekjchow1, 2016/10/24 22:43:09]

Should there be a StopWindowManager as well?

+  virtual void AddWebContents(content::WebContents* web_contents,

[derekjchow1, 2016/10/24 22:43:09]

How do we remove a WebContents from the window manager? Similarly, how do we add
something that's not a WebContents? How is z-ordering enforced for multiple
windows?

+                              bool is_overlay, bool is_transparent);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(CastWindowManager);
+};
+
+}  // namespace shell
+}  // namespace chromecast
+
+#endif  // CHROMECAST_BROWSER_CAST_WINDOW_MANAGER_H_