chrome/browser/android/tab_android.cc - Issue 2428383006: Decouple VR Shell DPR and CSS size from Physical Displays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2428383006: Decouple VR Shell DPR and CSS size from Physical Displays. (Closed)

Patch Set: Fix load-bearing debugging code ;) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index e0ecd6f0265b9a8a5f9d917a213b8f75fde1d94b..2e7a53dcbb83de0392d8a26b4e1eb6f8ec56de2e 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -695,7 +695,8 @@ ScopedJavaLocalRef<jobject> TabAndroid::GetFavicon(

SkBitmap favicon = favicon_driver->GetFavicon().AsBitmap();

if (!favicon.empty()) {

const float device_scale_factor =

- display::Screen::GetScreen()->GetPrimaryDisplay().device_scale_factor();

+ display::Screen::GetScreen()->GetDisplayNearestWindow(

+ web_contents_->GetNativeView()).device_scale_factor();

int target_size_dip = device_scale_factor * gfx::kFaviconSize;

if (favicon.width() != target_size_dip ||

favicon.height() != target_size_dip) {