Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java

Issue 2428383006: Decouple VR Shell DPR and CSS size from Physical Displays. (Closed)
Patch Set: Address bshe comments + minor fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/delegated_frame_host_android.cc ('k') | ui/snapshot/snapshot_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
diff --git a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
index dd0ed40a6bcc6081cc8d2f2a17bb45d938daffdb..fc60dd20831b3b554d11e1b868ea753fab43c084 100644
--- a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
+++ b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
@@ -91,7 +91,7 @@ public class WindowAndroid {
protected HashMap<Integer, String> mIntentErrors;
// We track all animations over content and provide a drawing placeholder for them.
- private HashSet<Animator> mAnimationsOverContent = new HashSet<Animator>();
+ private HashSet<Animator> mAnimationsOverContent = new HashSet<>();
private View mAnimationPlaceholderView;
private ViewGroup mKeyboardAccessoryView;
@@ -116,7 +116,7 @@ public class WindowAndroid {
public void keyboardVisibilityChanged(boolean isShowing);
}
private LinkedList<KeyboardVisibilityListener> mKeyboardVisibilityListeners =
- new LinkedList<KeyboardVisibilityListener>();
+ new LinkedList<>();
private final VSyncMonitor.Listener mVSyncListener = new VSyncMonitor.Listener() {
@Override
@@ -166,18 +166,26 @@ public class WindowAndroid {
/**
* @param context The application context.
*/
- @SuppressLint("UseSparseArrays")
public WindowAndroid(Context context) {
+ this(context, DisplayAndroid.getNonMultiDisplay(context));
+ }
+
+ /**
+ * @param context The application context.
+ * @param display
+ */
+ @SuppressLint("UseSparseArrays")
+ protected WindowAndroid(Context context, DisplayAndroid display) {
mApplicationContext = context.getApplicationContext();
// context does not have the same lifetime guarantees as an application context so we can't
// hold a strong reference to it.
- mContextRef = new WeakReference<Context>(context);
- mOutstandingIntents = new SparseArray<IntentCallback>();
- mIntentErrors = new HashMap<Integer, String>();
+ mContextRef = new WeakReference<>(context);
+ mOutstandingIntents = new SparseArray<>();
+ mIntentErrors = new HashMap<>();
mVSyncMonitor = new VSyncMonitor(context, mVSyncListener);
mAccessibilityManager = (AccessibilityManager) mApplicationContext.getSystemService(
Context.ACCESSIBILITY_SERVICE);
- mDisplayAndroid = DisplayAndroid.getNonMultiDisplay(context);
+ mDisplayAndroid = display;
}
@CalledByNative
@@ -411,7 +419,7 @@ public class WindowAndroid {
* this is in the context of a WebView that was not created using an Activity).
*/
public WeakReference<Activity> getActivity() {
- return new WeakReference<Activity>(null);
+ return new WeakReference<>(null);
}
/**
@@ -614,7 +622,7 @@ public class WindowAndroid {
// Clone the list in case a listener tries to remove itself during the callback.
LinkedList<KeyboardVisibilityListener> listeners =
- new LinkedList<KeyboardVisibilityListener>(mKeyboardVisibilityListeners);
+ new LinkedList<>(mKeyboardVisibilityListeners);
for (KeyboardVisibilityListener listener : listeners) {
listener.keyboardVisibilityChanged(isShowing);
}
@@ -663,7 +671,7 @@ public class WindowAndroid {
*/
public WeakReference<Context> getContext() {
// Return a new WeakReference to prevent clients from releasing our internal WeakReference.
- return new WeakReference<Context>(mContextRef.get());
+ return new WeakReference<>(mContextRef.get());
}
/**
« no previous file with comments | « ui/android/delegated_frame_host_android.cc ('k') | ui/snapshot/snapshot_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698