chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java - Issue 2428383006: Decouple VR Shell DPR and CSS size from Physical Displays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java

Issue 2428383006: Decouple VR Shell DPR and CSS size from Physical Displays. (Closed)

Patch Set: Address bshe comments + minor fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | chrome/browser/android/vr_shell/vr_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java

index 303d24d6e8603939e92664fb782b0782d1e1e5fa..3eb8b8840d746e6c18e0585cf5cce5d4a8c107ac 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java

@@ -17,6 +17,7 @@ import org.chromium.base.ApplicationStatus;

import org.chromium.base.Callback;

import org.chromium.ui.base.AndroidPermissionDelegate;

import org.chromium.ui.base.WindowAndroid;

+import org.chromium.ui.display.DisplayAndroid;

import java.lang.ref.WeakReference;

import java.util.Arrays;

@@ -25,12 +26,11 @@ import java.util.Arrays;

* The class provides the WindowAndroid's implementation which requires Activity Instance. It is

* only intended to be used when in VR.

-public class VrWindowAndroid

- extends WindowAndroid

+public class VrWindowAndroid extends WindowAndroid

implements ApplicationStatus.ActivityStateListener {

- public VrWindowAndroid(Context context) {

- super(context);

+ public VrWindowAndroid(Context context, DisplayAndroid display) {

+ super(context, display);

Activity activity = activityFromContext(context);

if (activity == null) {

throw new IllegalArgumentException("Context is not and does not wrap an Activity");