Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2428373005: Remove dependency on Fuchsia's runtime library. (Closed)

Created:
4 years, 2 months ago by kulakowski
Modified:
4 years, 2 months ago
Reviewers:
zra, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dependency on Fuchsia's runtime library. This library is no longer publicly exposed. The only functionality used by it is the utility function for printing mx errors, which has now moved into the vDSO and is available in <magenta/status.h>. R=zra@google.com, zra@chromium.org Committed: https://github.com/dart-lang/sdk/commit/9d292513687647b2d8aa6a4886da2d989c95b0ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/run_vm_tests_fuchsia.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kulakowski
cf https://fuchsia-review.googlesource.com/#/c/12789/
4 years, 2 months ago (2016-10-19 20:58:16 UTC) #1
zra
lgtm
4 years, 2 months ago (2016-10-19 21:00:35 UTC) #3
zra
4 years, 2 months ago (2016-10-19 22:09:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d292513687647b2d8aa6a4886da2d989c95b0ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698