Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issue 2428353004: Tearing off a top-level variable introduces a synthetic field which is added to the top-level class… (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tearing off a top-level variable introduces a synthetic field which is added to the top-level class not but the library. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/21a6f508928574c38ddcdc7ea47be192e26446d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/vm/precompiler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-19 22:10:59 UTC) #2
hausner
lgtm
4 years, 2 months ago (2016-10-19 22:27:56 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-19 22:34:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21a6f508928574c38ddcdc7ea47be192e26446d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698