Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/messages.h

Issue 2428343005: [wasm] Improve naming consistency for WASM instances. (Closed)
Patch Set: Also rename FrameArray::WasmObject Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The infrastructure used for (localized) message reporting in V8. 5 // The infrastructure used for (localized) message reporting in V8.
6 // 6 //
7 // Note: there's a big unresolved issue about ownership of the data 7 // Note: there's a big unresolved issue about ownership of the data
8 // structures used by this framework. 8 // structures used by this framework.
9 9
10 #ifndef V8_MESSAGES_H_ 10 #ifndef V8_MESSAGES_H_
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 bool force_constructor_; 119 bool force_constructor_;
120 bool is_strict_; 120 bool is_strict_;
121 121
122 friend class FrameArrayIterator; 122 friend class FrameArrayIterator;
123 }; 123 };
124 124
125 class WasmStackFrame : public StackFrameBase { 125 class WasmStackFrame : public StackFrameBase {
126 public: 126 public:
127 virtual ~WasmStackFrame() {} 127 virtual ~WasmStackFrame() {}
128 128
129 Handle<Object> GetReceiver() const override { return wasm_obj_; } 129 Handle<Object> GetReceiver() const override { return wasm_instance_; }
130 Handle<Object> GetFunction() const override; 130 Handle<Object> GetFunction() const override;
131 131
132 Handle<Object> GetFileName() override { return Null(); } 132 Handle<Object> GetFileName() override { return Null(); }
133 Handle<Object> GetFunctionName() override; 133 Handle<Object> GetFunctionName() override;
134 Handle<Object> GetScriptNameOrSourceUrl() override { return Null(); } 134 Handle<Object> GetScriptNameOrSourceUrl() override { return Null(); }
135 Handle<Object> GetMethodName() override { return Null(); } 135 Handle<Object> GetMethodName() override { return Null(); }
136 Handle<Object> GetTypeName() override { return Null(); } 136 Handle<Object> GetTypeName() override { return Null(); }
137 Handle<Object> GetEvalOrigin() override { return Null(); } 137 Handle<Object> GetEvalOrigin() override { return Null(); }
138 138
139 int GetPosition() const override; 139 int GetPosition() const override;
140 int GetLineNumber() override { return wasm_func_index_; } 140 int GetLineNumber() override { return wasm_func_index_; }
141 int GetColumnNumber() override { return -1; } 141 int GetColumnNumber() override { return -1; }
142 142
143 bool IsNative() override { return false; } 143 bool IsNative() override { return false; }
144 bool IsToplevel() override { return false; } 144 bool IsToplevel() override { return false; }
145 bool IsEval() override { return false; } 145 bool IsEval() override { return false; }
146 bool IsConstructor() override { return false; } 146 bool IsConstructor() override { return false; }
147 bool IsStrict() const override { return false; } 147 bool IsStrict() const override { return false; }
148 148
149 MaybeHandle<String> ToString() override; 149 MaybeHandle<String> ToString() override;
150 150
151 protected: 151 protected:
152 Handle<Object> Null() const; 152 Handle<Object> Null() const;
153 153
154 Isolate* isolate_; 154 Isolate* isolate_;
155 155
156 Handle<Object> wasm_obj_; 156 Handle<Object> wasm_instance_;
157 uint32_t wasm_func_index_; 157 uint32_t wasm_func_index_;
158 Handle<AbstractCode> code_; 158 Handle<AbstractCode> code_;
159 int offset_; 159 int offset_;
160 160
161 private: 161 private:
162 void FromFrameArray(Isolate* isolate, Handle<FrameArray> array, int frame_ix); 162 void FromFrameArray(Isolate* isolate, Handle<FrameArray> array, int frame_ix);
163 163
164 friend class FrameArrayIterator; 164 friend class FrameArrayIterator;
165 }; 165 };
166 166
(...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data); 702 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
703 static std::unique_ptr<char[]> GetLocalizedMessage(Isolate* isolate, 703 static std::unique_ptr<char[]> GetLocalizedMessage(Isolate* isolate,
704 Handle<Object> data); 704 Handle<Object> data);
705 }; 705 };
706 706
707 707
708 } // namespace internal 708 } // namespace internal
709 } // namespace v8 709 } // namespace v8
710 710
711 #endif // V8_MESSAGES_H_ 711 #endif // V8_MESSAGES_H_
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698