Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 24283002: GenerateGMs step on buildots: pass --ignoreTests arguments into gm (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

GenerateGMs step on buildots: pass --ignoreTests arguments into gm BUG=skia:1600 R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=11389

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M slave/skia_slave_scripts/run_gm.py View 2 chunks +32 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
epoger
https://codereview.chromium.org/24283002/diff/1/slave/skia_slave_scripts/run_gm.py File slave/skia_slave_scripts/run_gm.py (right): https://codereview.chromium.org/24283002/diff/1/slave/skia_slave_scripts/run_gm.py#newcode15 slave/skia_slave_scripts/run_gm.py:15: OVERRIDE_IGNORED_TESTS_FILE = 'ignored-tests.txt' Creation of this file is in ...
7 years, 3 months ago (2013-09-19 16:12:58 UTC) #1
borenet
LGTM
7 years, 3 months ago (2013-09-19 17:35:28 UTC) #2
epoger
7 years, 3 months ago (2013-09-19 17:39:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698