media/capture/video/win/video_capture_device_factory_win.cc - Issue 2428263004: 16 bpp video stream capture, render and createImageBitmap(video) using (CPU) shared memory buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/win/video_capture_device_factory_win.cc

Issue 2428263004: 16 bpp video stream capture, render and createImageBitmap(video) using (CPU) shared memory buffers (Closed)

Patch Set: Review #33 and #34 fixes. Removed WebGL part of code. Thanks danakj@ and mcasas@. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/win/video_capture_device_factory_win.cc

diff --git a/media/capture/video/win/video_capture_device_factory_win.cc b/media/capture/video/win/video_capture_device_factory_win.cc

index 7f4c7a0225e968cabef934a3948afec1c47769f0..07f63eda1678c50efc32aeae58ac79879df0e7fa 100644

--- a/media/capture/video/win/video_capture_device_factory_win.cc

+++ b/media/capture/video/win/video_capture_device_factory_win.cc

@@ -380,8 +380,10 @@ static void GetDeviceSupportedFormatsMediaFoundation(

VideoCaptureDeviceMFWin::FormatFromGuid(type_guid,

&capture_format.pixel_format);

type.Release();

- formats->push_back(capture_format);

++stream_index;

+ if (capture_format.pixel_format == PIXEL_FORMAT_UNKNOWN)

+ continue;

+ formats->push_back(capture_format);

DVLOG(1) << descriptor.display_name << " "

<< VideoCaptureFormat::ToString(capture_format);