16 bpp video stream capture, render and createImageBitmap(video) using (CPU) shared memory buffers

media/capture/video/win/video_capture_device_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/win/video_capture_device_win.h"
 
 #include <ks.h>
 #include <ksmedia.h>
 
 #include <algorithm>
 #include <list>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_variant.h"
 #include "media/base/timestamp_constants.h"
-#include "media/capture/video/blob_utils.h"
+#include "media/capture/video/video_capture_utils.h"
 
 using base::win::ScopedCoMem;
 using base::win::ScopedComPtr;
 using base::win::ScopedVariant;
 
 namespace media {
 
 #if DCHECK_IS_ON()
 #define DLOG_IF_FAILED_WITH_HRESULT(message, hr)                        \
   {                                                                     \
@@ skipping 138 matching lines @@
       {MEDIASUBTYPE_YUY2, PIXEL_FORMAT_YUY2},
       {MEDIASUBTYPE_MJPG, PIXEL_FORMAT_MJPEG},
       {MEDIASUBTYPE_UYVY, PIXEL_FORMAT_UYVY},
       {MEDIASUBTYPE_ARGB32, PIXEL_FORMAT_ARGB},
       {kMediaSubTypeHDYC, PIXEL_FORMAT_UYVY},
   };
   for (const auto& pixel_format : kMediaSubtypeToPixelFormatCorrespondence) {
     if (sub_type == pixel_format.sub_type)
       return pixel_format.format;
   }
+  if (IsY16FormatFourCc(sub_type.Data1)) {
+    return PIXEL_FORMAT_Y16;
+  }

[mcasas, 2016/10/21 00:10:51]

Here and in the equivalent MF version, I don't like
that you give special treatment to the Y16 formats.
We should do it more like the V4L2 delegate. I 
suggest: extend |kMediaSubtypeToPixelFormatCorrespondence|
with an entry for |Data1|. The currently existing
MEDIASUBTYPE_* won't have anything meaningful
there, and the Y16 will be listed individually, and
then you'll have a single for loop in l.174. Again, this
will also apply to video_capture_device_mf_win.cc .

[aleksandar.stojiljkovic, 2016/10/21 22:11:11]

No problem - I though it was a good idea to share the same code with
sink_input_pin_win.cc, but I'll just handle it the same way as kMediaSubTypeHDYC
and kMediaSubTypeI420 in [1]
https://cs.chromium.org/chromium/src/media/capture/video/win/sink_filter_win....

[aleksandar.stojiljkovic, 2016/10/24 14:57:49]

Done. Done like for other formats.

 #ifndef NDEBUG
   WCHAR guid_str[128];
   StringFromGUID2(sub_type, guid_str, arraysize(guid_str));
   DVLOG(2) << "Device (also) supports an unknown media type " << guid_str;
 #endif
   return PIXEL_FORMAT_UNKNOWN;
 }
 
 void VideoCaptureDeviceWin::ScopedMediaType::Free() {
   if (!media_type_)
@@ skipping 398 matching lines @@
 void VideoCaptureDeviceWin::SetErrorState(
     const tracked_objects::Location& from_here,
     const std::string& reason,
     HRESULT hr) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DLOG_IF_FAILED_WITH_HRESULT(reason, hr);
   state_ = kError;
   client_->OnError(from_here, reason);
 }
 }  // namespace media