16 bpp video stream capture, render and createImageBitmap(video) using (CPU) shared memory buffers

media/capture/video/fake_video_capture_device_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/fake_video_capture_device_factory.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_tokenizer.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "media/base/media_switches.h"
 
+namespace {
+
+media::VideoPixelFormat get_pixelformat(const std::string& device_id) {
+  if (device_id == "/dev/video1")
+    return media::PIXEL_FORMAT_Y16;
+  return media::PIXEL_FORMAT_I420;

[mcasas, 2016/10/21 00:10:50]

Hmm, if you need this specific format type to be generated, 
I'd say just add another sub flag and parse it appropriately:
https://cs.chromium.org/chromium/src/media/capture/video/fake_video_capture_d...

[aleksandar.stojiljkovic, 2016/10/21 22:11:10]

If it is important that there is only one capture device on the camera, maybe we
could have number_of_devices_ in a sub flag - with the depth/IR enabled cameras
it is common that the first device is color and the second is depth camera. I
think this way we test more as existing tests using 2 devices are also used for
testing (the point you made bellow).

+}
+}

[mcasas, 2016/10/21 00:10:50]

nit: empty line between these }

[aleksandar.stojiljkovic, 2016/10/21 22:11:10]

Done.

[aleksandar.stojiljkovic, 2016/10/25 21:14:59]

git cl format media is just forcing no empty line here and chromium presubmit
complains about it.

+
 namespace media {
 
 // Cap the frame rate command line input to reasonable values.
 static const float kFakeCaptureMinFrameRate = 5.0f;
 static const float kFakeCaptureMaxFrameRate = 60.0f;
 // Default rate if none is specified as part of the command line.
 static const float kFakeCaptureDefaultFrameRate = 20.0f;
 
 FakeVideoCaptureDeviceFactory::FakeVideoCaptureDeviceFactory()
+#if defined(OS_ANDROID)
+    // TODO(astojilj): Support 16bpp depth video capture on Android.
     : number_of_devices_(1),
+#else
+    // First device is I420, second is Y16. See also get_pixelformat().
+    : number_of_devices_(2),

[mcasas, 2016/10/21 00:10:50]

Some tests also set_numer_of_devices() to 2, and expect them,
are they still OK with this?

[aleksandar.stojiljkovic, 2016/10/21 22:11:10]

Yes, that's why decided to set it to 2, first RGB, second depth always - to
increase the coverage.
All seems to be handled properly - if I recall correctly, there was just
WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID that would fail
if there was no rendering support in cc.

+#endif
       fake_vcd_ownership_(FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS),
       frame_rate_(kFakeCaptureDefaultFrameRate) {}
 
 std::unique_ptr<VideoCaptureDevice> FakeVideoCaptureDeviceFactory::CreateDevice(
     const VideoCaptureDeviceDescriptor& device_descriptor) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   parse_command_line();
 
   for (int n = 0; n < number_of_devices_; ++n) {
     std::string possible_id = base::StringPrintf("/dev/video%d", n);
     if (device_descriptor.device_id.compare(possible_id) == 0) {
-      return std::unique_ptr<VideoCaptureDevice>(
-          new FakeVideoCaptureDevice(fake_vcd_ownership_, frame_rate_));
+      return std::unique_ptr<VideoCaptureDevice>(new FakeVideoCaptureDevice(
+          fake_vcd_ownership_, frame_rate_, get_pixelformat(possible_id)));
     }
   }
   return std::unique_ptr<VideoCaptureDevice>();
 }
 
 void FakeVideoCaptureDeviceFactory::GetDeviceDescriptors(
     VideoCaptureDeviceDescriptors* device_descriptors) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(device_descriptors->empty());
   for (int n = 0; n < number_of_devices_; ++n) {
     device_descriptors->emplace_back(base::StringPrintf("fake_device_%d", n),
                                      base::StringPrintf("/dev/video%d", n),
 #if defined(OS_LINUX)
                                      VideoCaptureApi::LINUX_V4L2_SINGLE_PLANE
 #elif defined(OS_MACOSX)
                                      VideoCaptureApi::MACOSX_AVFOUNDATION
 #elif defined(OS_WIN)
                                      VideoCaptureApi::WIN_DIRECT_SHOW
 #elif defined(OS_ANDROID)
                                      VideoCaptureApi::ANDROID_API2_LEGACY
 #endif
                                      );
   }
 }
 
 void FakeVideoCaptureDeviceFactory::GetSupportedFormats(
     const VideoCaptureDeviceDescriptor& device_descriptor,
     VideoCaptureFormats* supported_formats) {
   DCHECK(thread_checker_.CalledOnValidThread());
-  const gfx::Size supported_sizes[] = {gfx::Size(320, 240),
-                                       gfx::Size(640, 480),
+  const gfx::Size supported_sizes[] = {gfx::Size(96, 96),  // To test cubemap.
+                                       gfx::Size(320, 240), gfx::Size(640, 480),

[mcasas, 2016/10/21 00:10:50]

nit: Indent is strange here.

[aleksandar.stojiljkovic, 2016/10/21 22:11:10]

git cl format media is doing it and complaining if there is column layout like
before. Didn't know how to force it.

                                        gfx::Size(1280, 720),
                                        gfx::Size(1920, 1080)};
   supported_formats->clear();
   for (const auto& size : supported_sizes) {
-    supported_formats->push_back(
-        VideoCaptureFormat(size, frame_rate_, media::PIXEL_FORMAT_I420));
+    supported_formats->push_back(VideoCaptureFormat(
+        size, frame_rate_, get_pixelformat(device_descriptor.device_id)));
   }
 }
 
 // Optional comma delimited parameters to the command line can specify buffer
 // ownership, buffer planarity, and the fake video device FPS.
 // Examples: "ownership=client, planarity=triplanar, fps=60" "fps=30"
 void FakeVideoCaptureDeviceFactory::parse_command_line() {
   const std::string option =
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kUseFakeDeviceForMediaStream);
@@ skipping 20 matching lines @@
       if (base::StringToDouble(param.back(), &fps)) {
         frame_rate_ =
             std::max(kFakeCaptureMinFrameRate, static_cast<float>(fps));
         frame_rate_ = std::min(kFakeCaptureMaxFrameRate, frame_rate_);
       }
     }
   }
 }
 
 }  // namespace media