16 bpp video stream capture, render and createImageBitmap(video) using (CPU) shared memory buffers

content/browser/renderer_host/media/video_capture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_manager.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 71 matching lines @@
   if (formats->empty())
     return;
   std::sort(formats->begin(), formats->end(), IsCaptureFormatSmaller);
   // Due to the ordering imposed, the largest frame_rate is kept while removing
   // duplicated resolutions.
   media::VideoCaptureFormats::iterator last =
       std::unique(formats->begin(), formats->end(), IsCaptureFormatSizeEqual);
   formats->erase(last, formats->end());
   // Mark all formats as I420, since this is what the renderer side will get
   // anyhow: the actual pixel format is decided at the device level.
+  // Don't do this for Y16 format as it is handled separatelly.
   for (media::VideoCaptureFormats::iterator it = formats->begin();
        it != formats->end(); ++it) {
-    it->pixel_format = media::PIXEL_FORMAT_I420;
+    if (it->pixel_format != media::PIXEL_FORMAT_Y16)
+      it->pixel_format = media::PIXEL_FORMAT_I420;
   }

[mcasas, 2016/10/25 22:44:43]

Ugh, old code! Suggestion:

  for (const auto format : formats) {
    if (format.pixel_format != media::PIXEL_FORMAT_Y16)
      format.pixel_format = media::PIXEL_FORMAT_I420;
  }

[aleksandar.stojiljkovic, 2016/10/26 14:02:18]

Thanks. Done.

 }
 
 // The maximum number of buffers in the capture pipeline. See
 // VideoCaptureController ctor comments for more details.
 const int kMaxNumberOfBuffers = 3;
 // TODO(miu): The value for tab capture should be determined programmatically.
 // http://crbug.com/460318
 const int kMaxNumberOfBuffersForTabCapture = 10;
 
 // Used for logging capture events.
@@ skipping 1179 matching lines @@
     if (!device_in_queue) {
       // Session ID is only valid for Screen capture. So we can fake it to
       // resume video capture devices here.
       QueueStartDevice(kFakeSessionId, entry.get(), entry->parameters);
     }
   }
 }
 #endif  // defined(OS_ANDROID)
 
 }  // namespace content