Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3066)

Unified Diff: chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | chrome/browser/bookmarks/bookmark_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc
diff --git a/chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc b/chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc
index 95f49402cf936049393667267a83b50e5e04cb0d..8090ab8ac0e6ad1ef7a6c9a4b7c71158cdad12a8 100644
--- a/chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc
+++ b/chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc
@@ -8,7 +8,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/values.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
-#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "components/bookmarks/core/common/bookmark_pref_names.h"
BookmarkExpandedStateTracker::BookmarkExpandedStateTracker(
@@ -47,8 +47,8 @@ BookmarkExpandedStateTracker::GetExpandedNodes() {
int64 node_id;
const BookmarkNode* node;
if ((*i)->GetAsString(&value) && base::StringToInt64(value, &node_id) &&
- (node = bookmark_model_->GetNodeByID(node_id)) != NULL &&
- node->is_folder()) {
+ (node = bookmark_utils::GetNodeByID(bookmark_model_, node_id)) !=
+ NULL && node->is_folder()) {
nodes.insert(node);
} else {
changed = true;
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | chrome/browser/bookmarks/bookmark_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698