chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc - Issue 242823002: Extract GetNodeByID() method from BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

index b9eaef4148fcbb895b77e59e78731965bf1b8031..ef43cf00b1c453a0f06f98a40e1b53596bb43c25 100644

--- a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

+++ b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/android/tab_android.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

+#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/profiles/incognito_helpers.h"

#include "chrome/browser/profiles/profile.h"

@@ -520,7 +521,7 @@ const BookmarkNode* BookmarksHandler::GetNodeByID(

if (is_partner)

return partner_bookmarks_shim_->GetNodeByID(id);

- return bookmark_model_->GetNodeByID(id);

+ return GetBookmarkNodeByID(bookmark_model_, id);

}

const BookmarkNode* BookmarksHandler::GetParentOf(