chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 242823002: Extract GetNodeByID() method from BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index fe473f825b4e002ce60df0ee79b599247a1929d6..25b267f6043e53750f5c1176988ddae5bc15c277 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -13,6 +13,7 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_node_data.h"

#include "chrome/browser/bookmarks/bookmark_stats.h"

+#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_properties.h"

@@ -1025,7 +1026,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {

- (IBAction)openBookmarkMenuItem:(id)sender {

int64 tag = [self nodeIdFromMenuTag:[sender tag]];

- const BookmarkNode* node = bookmarkModel_->GetNodeByID(tag);

+ const BookmarkNode* node = GetBookmarkNodeByID(bookmarkModel_, tag);

WindowOpenDisposition disposition =

ui::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);

[self openURL:node->url() disposition:disposition];