chrome/browser/history/android/bookmark_model_sql_handler.cc - Issue 242823002: Extract GetNodeByID() method from BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/bookmark_model_sql_handler.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/android/bookmark_model_sql_handler.cc

diff --git a/chrome/browser/history/android/bookmark_model_sql_handler.cc b/chrome/browser/history/android/bookmark_model_sql_handler.cc

index 446d2af2b8d41320097740940009507db5a0bb95..392087ca116c08108b1438b6552b62895b4e3771 100644

--- a/chrome/browser/history/android/bookmark_model_sql_handler.cc

+++ b/chrome/browser/history/android/bookmark_model_sql_handler.cc

@@ -8,6 +8,7 @@

#include "chrome/browser/bookmarks/bookmark_model.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_service.h"

+#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/history/url_database.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -46,7 +47,7 @@ void BookmarkModelSQLHandler::Task::AddBookmark(const GURL& url,

BookmarkModel* bookmark_model = GetBookmarkModel();

if (!bookmark_model)

return;

- const BookmarkNode* parent = bookmark_model->GetNodeByID(parent_id);

+ const BookmarkNode* parent = GetBookmarkNodeByID(bookmark_model, parent_id);

if (parent)

bookmark_model->AddURL(parent, 0, title, url);

}