Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_expanded_state_tracker.h" 5 #include "chrome/browser/bookmarks/bookmark_expanded_state_tracker.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
11 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 11 #include "chrome/browser/bookmarks/bookmark_utils.h"
12 #include "components/bookmarks/core/common/bookmark_pref_names.h" 12 #include "components/bookmarks/core/common/bookmark_pref_names.h"
13 13
14 BookmarkExpandedStateTracker::BookmarkExpandedStateTracker( 14 BookmarkExpandedStateTracker::BookmarkExpandedStateTracker(
15 BookmarkModel* bookmark_model, 15 BookmarkModel* bookmark_model,
16 PrefService* pref_service) 16 PrefService* pref_service)
17 : bookmark_model_(bookmark_model), 17 : bookmark_model_(bookmark_model),
18 pref_service_(pref_service) { 18 pref_service_(pref_service) {
19 bookmark_model->AddObserver(this); 19 bookmark_model->AddObserver(this);
20 } 20 }
21 21
(...skipping 18 matching lines...) Expand all
40 if (!value) 40 if (!value)
41 return nodes; 41 return nodes;
42 42
43 bool changed = false; 43 bool changed = false;
44 for (base::ListValue::const_iterator i = value->begin(); 44 for (base::ListValue::const_iterator i = value->begin();
45 i != value->end(); ++i) { 45 i != value->end(); ++i) {
46 std::string value; 46 std::string value;
47 int64 node_id; 47 int64 node_id;
48 const BookmarkNode* node; 48 const BookmarkNode* node;
49 if ((*i)->GetAsString(&value) && base::StringToInt64(value, &node_id) && 49 if ((*i)->GetAsString(&value) && base::StringToInt64(value, &node_id) &&
50 (node = bookmark_model_->GetNodeByID(node_id)) != NULL && 50 (node = GetBookmarkNodeByID(bookmark_model_, node_id)) != NULL &&
51 node->is_folder()) { 51 node->is_folder()) {
52 nodes.insert(node); 52 nodes.insert(node);
53 } else { 53 } else {
54 changed = true; 54 changed = true;
55 } 55 }
56 } 56 }
57 if (changed) 57 if (changed)
58 UpdatePrefs(nodes); 58 UpdatePrefs(nodes);
59 return nodes; 59 return nodes;
60 } 60 }
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 return; 99 return;
100 100
101 base::ListValue values; 101 base::ListValue values;
102 for (Nodes::const_iterator i = nodes.begin(); i != nodes.end(); ++i) { 102 for (Nodes::const_iterator i = nodes.begin(); i != nodes.end(); ++i) {
103 values.Set(values.GetSize(), 103 values.Set(values.GetSize(),
104 new base::StringValue(base::Int64ToString((*i)->id()))); 104 new base::StringValue(base::Int64ToString((*i)->id())));
105 } 105 }
106 106
107 pref_service_->Set(prefs::kBookmarkEditorExpandedNodes, values); 107 pref_service_->Set(prefs::kBookmarkEditorExpandedNodes, values);
108 } 108 }
OLDNEW
« no previous file with comments | « chrome/browser/android/provider/chrome_browser_provider.cc ('k') | chrome/browser/bookmarks/bookmark_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698