Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 24282005: Move compile-time constant registrations to the backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart
index 4803e8640cc065f7f97b89bb24af61930b10b0c0..108add765cb9073adcb4e9e2909af1dd8c22fae3 100644
--- a/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -123,6 +123,13 @@ abstract class Backend {
bool classNeedsRti(ClassElement cls);
bool methodNeedsRti(FunctionElement function);
+
+ /// Called by the backend when [constant] has been used.
ngeoffray 2013/10/01 08:33:35 Please update comment: how can that be called by t
Johnni Winther 2013/10/01 11:21:48 Done.
+ void registerCompileTimeConstant(Constant constant, TreeElements elements) {}
+
+ /// Called during post-processing when [constant] has been evaluated.
+ void registerMetadataConstant(Constant constant, TreeElements elements) {}
+
/// Called during resolution to notify to the backend that a class is
/// being instantiated.
void registerInstantiatedClass(ClassElement cls,
@@ -257,10 +264,6 @@ abstract class Backend {
return new Future.value();
}
- void registerMetadataInstantiatedType(DartType type, TreeElements elements) {}
- void registerMetadataStaticUse(Element element) {}
- void registerMetadataGetOfStaticFunction(FunctionElement element) {}
-
/// Called by [MirrorUsageAnalyzerTask] after it has merged all @MirrorsUsed
/// annotations. The arguments corresponds to the unions of the corresponding
/// fields of the annotations.
@@ -529,7 +532,6 @@ abstract class Compiler implements DiagnosticListener {
ti.TypesTask typesTask;
Backend backend;
ConstantHandler constantHandler;
- ConstantHandler metadataHandler;
EnqueueTask enqueuer;
DeferredLoadTask deferredLoadTask;
MirrorUsageAnalyzerTask mirrorUsageAnalyzerTask;
@@ -644,8 +646,6 @@ abstract class Compiler implements DiagnosticListener {
enqueuer = new EnqueueTask(this)];
tasks.addAll(backend.tasks);
- metadataHandler = new ConstantHandler(
- this, backend.constantSystem, isMetadata: true);
}
Universe get resolverWorld => enqueuer.resolution.universe;

Powered by Google App Engine
This is Rietveld 408576698