Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 24282003: remove ez_setup import from setup.py (Closed)

Created:
7 years, 3 months ago by ericvw
Modified:
7 years, 3 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

remove ez_setup import from setup.py During the review for commit r1713 it was determined that ez_setup.py was not going to be part of the commit. While ez_setup.py was removed as requested, the import and usage of ez_setup in setup.py was not removed appropriately. This change removes the import and usage so that installing gyp via setuptools works as expected. Committed GYP r1736

Patch Set 1 #

Patch Set 2 : added Eric N. Vander Weele <ericvw@gmail.com> to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M setup.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ericvw
7 years, 3 months ago (2013-09-19 17:33:55 UTC) #1
scottmg
lgtm
7 years, 3 months ago (2013-09-19 17:36:53 UTC) #2
ericvw
If someone could commit on my behalf, that would be great. Thanks!
7 years, 3 months ago (2013-09-19 17:38:01 UTC) #3
Shezan Baig (Bloomberg)
mal, can you verify the AUTHORS change? Thanks!
7 years, 3 months ago (2013-09-19 18:42:36 UTC) #4
Mark Mentovai
This is fine for GYP, including the AUTHORS file. LGTM.
7 years, 3 months ago (2013-09-19 18:48:27 UTC) #5
Shezan Baig (Bloomberg)
On 2013/09/19 18:48:27, Mark Mentovai wrote: > This is fine for GYP, including the AUTHORS ...
7 years, 3 months ago (2013-09-19 19:06:39 UTC) #6
Mark Mentovai
7 years, 3 months ago (2013-09-19 19:23:31 UTC) #7
I don’t know anything about git cl dcommit, but I suspect the prompts were for
it trying to mark this code review (https://codereview.chromium.org/24282003) as
“closed.” Since you aren’t the creator of the issue, you don’t have permission
to close it.

I can close it, though.

Powered by Google App Engine
This is Rietveld 408576698