[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG=653836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c262d27647ccc3887bee4a9f8f6727b8d0ce474e
Cr-Commit-Position: refs/heads/master@{#427195}

[Moe, 2016-10-18 16:55:25]

Description was changed from

==========
[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG=653836
==========

to

==========
[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG=653836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-10-18 16:55:49]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 16:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:49:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Moe, 2016-10-20 14:10:02]

mahmadi@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Moe, 2016-10-20 14:10:02]

Hi Michael, Please review this CL.

[michaelpg, 2016-10-22 05:04:17]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-10-22 05:04:18]

looks fine, but dbeam is likely to know whether this is "right"

[Dan Beam, 2016-10-24 21:28:05]

i think michaelpg@ was talking about "rightness" as we're overriding something
without any real way of detecting if it's changing.

also, Polymer used to use _singleUnder for private, but then changed to
_protected and __private or something.  that's never been super clear to me. 
basically: it's not clear whether you're overriding a @protected or @private
method.

it'd also be way better if we could use @override (and not copy the description,
and get a closure compiler error if the method gets renamed), but I'm guessing
that doesn't work?

[Dan Beam, 2016-10-24 21:29:10]

oh, also lgtm

i honestly don't know what i think should happen, though.  pressing escape in an
<input> and <textarea> doesn't really do much, so I suppose we should emulate
that (which is what you're doing).

[Moe, 2016-10-24 23:19:52]

Thank you both.

Dan, yes unfortunately the Polymer Pass isn't smart enough for @override to
work.

[Moe, 2016-10-24 23:19:57]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:20:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:51:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 00:54:06]

Description was changed from

==========
[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG=653836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG=653836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c262d27647ccc3887bee4a9f8f6727b8d0ce474e
Cr-Commit-Position: refs/heads/master@{#427195}
==========

[commit-bot: I haz the power, 2016-10-25 00:54:07]

Patchset 1 (id:??) landed as
https://crrev.com/c262d27647ccc3887bee4a9f8f6727b8d0ce474e
Cr-Commit-Position: refs/heads/master@{#427195}