Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
242803007:
Re-land: cc: Enable impl-side painting by default on all platforms where threaded composit... (Closed)
|
Created:
6 years, 8 months ago by reveman Modified:
6 years, 7 months ago CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRe-land: cc: Enable impl-side painting by default on all platforms where threaded compositing is used.
BUG=169282
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266654
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 29 (0 generated)
Let's do this. I'll make sure to give people a heads up by sending an email to graphics-dev@ before this lands.
LGTM.
lgtm2
On 2014/04/24 19:58:53, enne wrote: > lgtm2 Damn the torpedoes! LGTM
The CQ bit was checked by reveman@chromium.org
The CQ bit was unchecked by reveman@chromium.org
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/242803007/1
Can you make sure this doesn't break layout tests while this is in the cq?
On 2014/04/25 22:31:27, danakj wrote: > Can you make sure this doesn't break layout tests while this is in the cq? Layout tests on windows? I assumed that this change doesn't affect the configuration used for layout tests. Is that not the case?
https://codereview.chromium.org/242803007/diff/1/content/browser/gpu/composit... File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/242803007/diff/1/content/browser/gpu/composit... content/browser/gpu/compositor_util.cc:211: return true; Drive-by: return IsThreadedCompositingEnabled(); ? :)
https://codereview.chromium.org/242803007/diff/1/content/browser/gpu/composit... File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/242803007/diff/1/content/browser/gpu/composit... content/browser/gpu/compositor_util.cc:211: return true; On 2014/04/25 23:04:56, abarth wrote: > Drive-by: > > return IsThreadedCompositingEnabled(); > > ? :) Done :)
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/242803007/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/242803007/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/242803007/20001
Message was sent while issue was closed.
Change committed as 266471
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/259843006/ by pfeldman@chromium.org. The reason for reverting is: This makes DevTools unusable on Linux Aura, see crbug.com/367673..
Message was sent while issue was closed.
On 2014/04/28 10:11:04, pfeldman wrote: > A revert of this CL has been created in > https://codereview.chromium.org/259843006/ by mailto:pfeldman@chromium.org. > > The reason for reverting is: This makes DevTools unusable on Linux Aura, see > crbug.com/367673.. Pretty sure this was caused by crbug.com/366889. I'll re-land this change once the fix for that has made it into chromium and I've verified that this is no longer a problem.
On 2014/04/28 17:23:22, reveman wrote: > On 2014/04/28 10:11:04, pfeldman wrote: > > A revert of this CL has been created in > > https://codereview.chromium.org/259843006/ by mailto:pfeldman@chromium.org. > > > > The reason for reverting is: This makes DevTools unusable on Linux Aura, see > > crbug.com/367673.. > > Pretty sure this was caused by crbug.com/366889. I'll re-land this change once > the fix for that has made it into chromium and I've verified that this is no > longer a problem. I'll re-land this now that I've verified that devtools works correctly in ToT.
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/242803007/20001
Message was sent while issue was closed.
Change committed as 266654 |
