Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4194)

Unified Diff: base/task_scheduler/task_tracker_posix_unittest.cc

Issue 2427963002: Support FileDescriptorWatcher in TaskScheduler. (Closed)
Patch Set: fix build error (add BASE_EXPORT) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_tracker_posix.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_tracker_posix_unittest.cc
diff --git a/base/task_scheduler/task_tracker_posix_unittest.cc b/base/task_scheduler/task_tracker_posix_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b654a6d54380ab68b7d4fdc0fa50bc1c02242729
--- /dev/null
+++ b/base/task_scheduler/task_tracker_posix_unittest.cc
@@ -0,0 +1,65 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/task_tracker_posix.h"
+
+#include <unistd.h>
+
+#include <utility>
+
+#include "base/bind.h"
+#include "base/files/file_descriptor_watcher_posix.h"
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/posix/eintr_wrapper.h"
+#include "base/run_loop.h"
+#include "base/sequence_token.h"
+#include "base/task_scheduler/task.h"
+#include "base/task_scheduler/task_traits.h"
+#include "base/time/time.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+namespace internal {
+
+// Verify that TaskTrackerPosix runs a Task it receives.
+TEST(TaskSchedulerTaskTrackerPosixTest, RunTask) {
+ MessageLoopForIO message_loop;
+ bool did_run = false;
+ auto task = MakeUnique<Task>(
+ FROM_HERE,
+ Bind([](bool* did_run) { *did_run = true; }, Unretained(&did_run)),
+ TaskTraits(), TimeDelta());
+ TaskTrackerPosix tracker(&message_loop);
+
+ EXPECT_TRUE(tracker.WillPostTask(task.get()));
+ EXPECT_TRUE(tracker.RunTask(std::move(task), SequenceToken::Create()));
+ EXPECT_TRUE(did_run);
+}
+
+// Verify that FileDescriptorWatcher::WatchReadable() can be called from a task
+// running in TaskTrackerPosix without a crash.
+TEST(TaskSchedulerTaskTrackerPosixTest, FileDescriptorWatcher) {
+ MessageLoopForIO message_loop;
+ int fds[2];
+ ASSERT_EQ(0, pipe(fds));
+ auto task = MakeUnique<Task>(
+ FROM_HERE, Bind(IgnoreResult(&FileDescriptorWatcher::WatchReadable),
+ fds[0], Bind(&DoNothing)),
+ TaskTraits(), TimeDelta());
+ TaskTrackerPosix tracker(&message_loop);
+
+ EXPECT_TRUE(tracker.WillPostTask(task.get()));
+ EXPECT_TRUE(tracker.RunTask(std::move(task), SequenceToken::Create()));
+
+ // Run the MessageLoop to allow the read watch to be registered and
+ // unregistered. This prevents a memory leak.
+ RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(0, IGNORE_EINTR(close(fds[0])));
+ EXPECT_EQ(0, IGNORE_EINTR(close(fds[1])));
+}
+
+} // namespace internal
+} // namespace base
« no previous file with comments | « base/task_scheduler/task_tracker_posix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698