Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Side by Side Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2427963002: Support FileDescriptorWatcher in TaskScheduler. (Closed)
Patch Set: nacl Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler_impl.h" 5 #include "base/task_scheduler/task_scheduler_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/task_scheduler/scheduler_worker_pool_params.h" 12 #include "base/task_scheduler/scheduler_worker_pool_params.h"
13 #include "base/task_scheduler/sequence_sort_key.h" 13 #include "base/task_scheduler/sequence_sort_key.h"
14 #include "base/task_scheduler/task.h" 14 #include "base/task_scheduler/task.h"
15 #include "base/time/time.h" 15 #include "base/time/time.h"
16 #include "build/build_config.h"
16 17
17 namespace base { 18 namespace base {
18 namespace internal { 19 namespace internal {
19 20
20 // static 21 // static
21 std::unique_ptr<TaskSchedulerImpl> TaskSchedulerImpl::Create( 22 std::unique_ptr<TaskSchedulerImpl> TaskSchedulerImpl::Create(
22 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector, 23 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
23 const WorkerPoolIndexForTraitsCallback& 24 const WorkerPoolIndexForTraitsCallback&
24 worker_pool_index_for_traits_callback) { 25 worker_pool_index_for_traits_callback) {
25 std::unique_ptr<TaskSchedulerImpl> scheduler( 26 std::unique_ptr<TaskSchedulerImpl> scheduler(
(...skipping 20 matching lines...) Expand all
46 47
47 scoped_refptr<TaskRunner> TaskSchedulerImpl::CreateTaskRunnerWithTraits( 48 scoped_refptr<TaskRunner> TaskSchedulerImpl::CreateTaskRunnerWithTraits(
48 const TaskTraits& traits, 49 const TaskTraits& traits,
49 ExecutionMode execution_mode) { 50 ExecutionMode execution_mode) {
50 return GetWorkerPoolForTraits(traits)->CreateTaskRunnerWithTraits( 51 return GetWorkerPoolForTraits(traits)->CreateTaskRunnerWithTraits(
51 traits, execution_mode); 52 traits, execution_mode);
52 } 53 }
53 54
54 void TaskSchedulerImpl::Shutdown() { 55 void TaskSchedulerImpl::Shutdown() {
55 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown. 56 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown.
56 task_tracker_.Shutdown(); 57 DCHECK(task_tracker_);
58 task_tracker_->Shutdown();
57 } 59 }
58 60
59 void TaskSchedulerImpl::FlushForTesting() { 61 void TaskSchedulerImpl::FlushForTesting() {
60 task_tracker_.Flush(); 62 DCHECK(task_tracker_);
63 task_tracker_->Flush();
61 } 64 }
62 65
63 void TaskSchedulerImpl::JoinForTesting() { 66 void TaskSchedulerImpl::JoinForTesting() {
64 #if DCHECK_IS_ON() 67 #if DCHECK_IS_ON()
65 DCHECK(!join_for_testing_returned_.IsSet()); 68 DCHECK(!join_for_testing_returned_.IsSet());
66 #endif 69 #endif
67 for (const auto& worker_pool : worker_pools_) 70 for (const auto& worker_pool : worker_pools_)
68 worker_pool->JoinForTesting(); 71 worker_pool->JoinForTesting();
69 service_thread_.Stop(); 72 service_thread_.Stop();
70 #if DCHECK_IS_ON() 73 #if DCHECK_IS_ON()
71 join_for_testing_returned_.Set(); 74 join_for_testing_returned_.Set();
72 #endif 75 #endif
73 } 76 }
74 77
75 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback& 78 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback&
76 worker_pool_index_for_traits_callback) 79 worker_pool_index_for_traits_callback)
77 : service_thread_("TaskSchedulerServiceThread"), 80 : service_thread_("TaskSchedulerServiceThread"),
78 worker_pool_index_for_traits_callback_( 81 worker_pool_index_for_traits_callback_(
79 worker_pool_index_for_traits_callback) { 82 worker_pool_index_for_traits_callback) {
80 DCHECK(!worker_pool_index_for_traits_callback_.is_null()); 83 DCHECK(!worker_pool_index_for_traits_callback_.is_null());
81 } 84 }
82 85
83 void TaskSchedulerImpl::Initialize( 86 void TaskSchedulerImpl::Initialize(
84 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector) { 87 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector) {
85 DCHECK(!worker_pool_params_vector.empty()); 88 DCHECK(!worker_pool_params_vector.empty());
86 89
87 // Start the service thread. 90 // Start the service thread.
88 constexpr MessageLoop::Type kServiceThreadMessageLoopType = 91 constexpr MessageLoop::Type kServiceThreadMessageLoopType =
89 #if defined(OS_POSIX) 92 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
90 MessageLoop::TYPE_IO; 93 MessageLoop::TYPE_IO;
91 #else 94 #else
92 MessageLoop::TYPE_DEFAULT; 95 MessageLoop::TYPE_DEFAULT;
93 #endif 96 #endif
94 constexpr size_t kDefaultStackSize = 0; 97 constexpr size_t kDefaultStackSize = 0;
95 CHECK(service_thread_.StartWithOptions( 98 CHECK(service_thread_.StartWithOptions(
96 Thread::Options(kServiceThreadMessageLoopType, kDefaultStackSize))); 99 Thread::Options(kServiceThreadMessageLoopType, kDefaultStackSize)));
97 100
101 task_tracker_ = MakeUnique<TaskTracker>(
102 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
103 static_cast<MessageLoopForIO*>(service_thread_.message_loop())
104 #endif
105 );
106
98 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback 107 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
99 re_enqueue_sequence_callback = 108 re_enqueue_sequence_callback =
100 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this)); 109 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
101 110
102 // Instantiate the DelayedTaskManager. The service thread must be started 111 // Instantiate the DelayedTaskManager. The service thread must be started
103 // before its TaskRunner is available. 112 // before its TaskRunner is available.
104 delayed_task_manager_ = 113 delayed_task_manager_ =
105 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner()); 114 MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
106 115
107 // Start worker pools. 116 // Start worker pools.
108 for (const auto& worker_pool_params : worker_pool_params_vector) { 117 for (const auto& worker_pool_params : worker_pool_params_vector) {
109 // Passing pointers to objects owned by |this| to 118 // Passing pointers to objects owned by |this| to
110 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl 119 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl
111 // can't be deleted before all its worker pools have been joined. 120 // can't be deleted before all its worker pools have been joined.
112 worker_pools_.push_back(SchedulerWorkerPoolImpl::Create( 121 worker_pools_.push_back(SchedulerWorkerPoolImpl::Create(
113 worker_pool_params, re_enqueue_sequence_callback, &task_tracker_, 122 worker_pool_params, re_enqueue_sequence_callback, task_tracker_.get(),
114 delayed_task_manager_.get())); 123 delayed_task_manager_.get()));
115 CHECK(worker_pools_.back()); 124 CHECK(worker_pools_.back());
116 } 125 }
117 } 126 }
118 127
119 SchedulerWorkerPool* TaskSchedulerImpl::GetWorkerPoolForTraits( 128 SchedulerWorkerPool* TaskSchedulerImpl::GetWorkerPoolForTraits(
120 const TaskTraits& traits) { 129 const TaskTraits& traits) {
121 const size_t index = worker_pool_index_for_traits_callback_.Run(traits); 130 const size_t index = worker_pool_index_for_traits_callback_.Run(traits);
122 DCHECK_LT(index, worker_pools_.size()); 131 DCHECK_LT(index, worker_pools_.size());
123 return worker_pools_[index].get(); 132 return worker_pools_[index].get();
(...skipping 10 matching lines...) Expand all
134 // in |sequence|. 143 // in |sequence|.
135 const TaskTraits traits = 144 const TaskTraits traits =
136 sequence->PeekTaskTraits().WithPriority(sort_key.priority()); 145 sequence->PeekTaskTraits().WithPriority(sort_key.priority());
137 146
138 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence), 147 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
139 sort_key); 148 sort_key);
140 } 149 }
141 150
142 } // namespace internal 151 } // namespace internal
143 } // namespace base 152 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698