Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2427963002: Support FileDescriptorWatcher in TaskScheduler. (Closed)
Patch Set: fix build error (add BASE_EXPORT) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | base/task_scheduler/task_tracker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler_impl.h" 5 #include "base/task_scheduler/task_scheduler_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/metrics/histogram_base.h" 12 #include "base/task_scheduler/delayed_task_manager.h"
13 #include "base/task_scheduler/scheduler_worker_pool_params.h" 13 #include "base/task_scheduler/scheduler_worker_pool_params.h"
14 #include "base/task_scheduler/sequence_sort_key.h" 14 #include "base/task_scheduler/sequence_sort_key.h"
15 #include "base/task_scheduler/task.h" 15 #include "base/task_scheduler/task.h"
16 #include "base/task_scheduler/task_tracker.h"
16 #include "base/time/time.h" 17 #include "base/time/time.h"
18 #include "build/build_config.h"
19
20 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
21 #include "base/task_scheduler/task_tracker_posix.h"
22 #endif
17 23
18 namespace base { 24 namespace base {
19 namespace internal { 25 namespace internal {
20 26
21 // static 27 // static
22 std::unique_ptr<TaskSchedulerImpl> TaskSchedulerImpl::Create( 28 std::unique_ptr<TaskSchedulerImpl> TaskSchedulerImpl::Create(
23 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector, 29 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
24 const WorkerPoolIndexForTraitsCallback& 30 const WorkerPoolIndexForTraitsCallback&
25 worker_pool_index_for_traits_callback) { 31 worker_pool_index_for_traits_callback) {
26 std::unique_ptr<TaskSchedulerImpl> scheduler( 32 std::unique_ptr<TaskSchedulerImpl> scheduler(
(...skipping 28 matching lines...) Expand all
55 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const { 61 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const {
56 std::vector<const HistogramBase*> histograms; 62 std::vector<const HistogramBase*> histograms;
57 for (const auto& worker_pool : worker_pools_) 63 for (const auto& worker_pool : worker_pools_)
58 worker_pool->GetHistograms(&histograms); 64 worker_pool->GetHistograms(&histograms);
59 65
60 return histograms; 66 return histograms;
61 } 67 }
62 68
63 void TaskSchedulerImpl::Shutdown() { 69 void TaskSchedulerImpl::Shutdown() {
64 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown. 70 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown.
65 task_tracker_.Shutdown(); 71 DCHECK(task_tracker_);
72 task_tracker_->Shutdown();
66 } 73 }
67 74
68 void TaskSchedulerImpl::FlushForTesting() { 75 void TaskSchedulerImpl::FlushForTesting() {
69 task_tracker_.Flush(); 76 DCHECK(task_tracker_);
77 task_tracker_->Flush();
70 } 78 }
71 79
72 void TaskSchedulerImpl::JoinForTesting() { 80 void TaskSchedulerImpl::JoinForTesting() {
73 #if DCHECK_IS_ON() 81 #if DCHECK_IS_ON()
74 DCHECK(!join_for_testing_returned_.IsSet()); 82 DCHECK(!join_for_testing_returned_.IsSet());
75 #endif 83 #endif
76 for (const auto& worker_pool : worker_pools_) 84 for (const auto& worker_pool : worker_pools_)
77 worker_pool->JoinForTesting(); 85 worker_pool->JoinForTesting();
78 service_thread_.Stop(); 86 service_thread_.Stop();
79 #if DCHECK_IS_ON() 87 #if DCHECK_IS_ON()
80 join_for_testing_returned_.Set(); 88 join_for_testing_returned_.Set();
81 #endif 89 #endif
82 } 90 }
83 91
84 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback& 92 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback&
85 worker_pool_index_for_traits_callback) 93 worker_pool_index_for_traits_callback)
86 : service_thread_("TaskSchedulerServiceThread"), 94 : service_thread_("TaskSchedulerServiceThread"),
87 worker_pool_index_for_traits_callback_( 95 worker_pool_index_for_traits_callback_(
88 worker_pool_index_for_traits_callback) { 96 worker_pool_index_for_traits_callback) {
89 DCHECK(!worker_pool_index_for_traits_callback_.is_null()); 97 DCHECK(!worker_pool_index_for_traits_callback_.is_null());
90 } 98 }
91 99
92 void TaskSchedulerImpl::Initialize( 100 void TaskSchedulerImpl::Initialize(
93 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector) { 101 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector) {
94 DCHECK(!worker_pool_params_vector.empty()); 102 DCHECK(!worker_pool_params_vector.empty());
95 103
96 // Start the service thread. On POSIX, the service thread runs a 104 // Start the service thread. On platforms that support it (POSIX except NaCL
97 // MessageLoopForIO to support FileDescriptorWatcher. 105 // SFI), the service thread runs a MessageLoopForIO which is used to support
106 // FileDescriptorWatcher in the scope in which tasks run.
98 constexpr MessageLoop::Type kServiceThreadMessageLoopType = 107 constexpr MessageLoop::Type kServiceThreadMessageLoopType =
99 #if defined(OS_POSIX) 108 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
100 MessageLoop::TYPE_IO; 109 MessageLoop::TYPE_IO;
101 #else 110 #else
102 MessageLoop::TYPE_DEFAULT; 111 MessageLoop::TYPE_DEFAULT;
103 #endif 112 #endif
104 constexpr size_t kDefaultStackSize = 0; 113 constexpr size_t kDefaultStackSize = 0;
105 CHECK(service_thread_.StartWithOptions( 114 CHECK(service_thread_.StartWithOptions(
106 Thread::Options(kServiceThreadMessageLoopType, kDefaultStackSize))); 115 Thread::Options(kServiceThreadMessageLoopType, kDefaultStackSize)));
107 116
108 // Instantiate the DelayedTaskManager. The service thread must be started 117 // Instantiate TaskTracker. Needs to happen after starting the service thread
109 // before its TaskRunner is available. 118 // to get its message_loop().
119 task_tracker_ =
120 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
121 base::MakeUnique<TaskTrackerPosix>(
122 static_cast<MessageLoopForIO*>(service_thread_.message_loop()));
123 #else
124 base::MakeUnique<TaskTracker>();
125 #endif
126
127 // Instantiate DelayedTaskManager. Needs to happen after starting the service
128 // thread to get its task_runner().
110 delayed_task_manager_ = 129 delayed_task_manager_ =
111 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner()); 130 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
112 131
132 // Callback invoked by workers to re-enqueue a sequence in the appropriate
133 // PriorityQueue.
113 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback 134 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
114 re_enqueue_sequence_callback = 135 re_enqueue_sequence_callback =
115 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this)); 136 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
116 137
117 // Start worker pools. 138 // Start worker pools.
118 for (const auto& worker_pool_params : worker_pool_params_vector) { 139 for (const auto& worker_pool_params : worker_pool_params_vector) {
119 // Passing pointers to objects owned by |this| to 140 // Passing pointers to objects owned by |this| to
120 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl 141 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl
121 // can't be deleted before all its worker pools have been joined. 142 // can't be deleted before all its worker pools have been joined.
122 worker_pools_.push_back(SchedulerWorkerPoolImpl::Create( 143 worker_pools_.push_back(SchedulerWorkerPoolImpl::Create(
123 worker_pool_params, re_enqueue_sequence_callback, &task_tracker_, 144 worker_pool_params, re_enqueue_sequence_callback, task_tracker_.get(),
124 delayed_task_manager_.get())); 145 delayed_task_manager_.get()));
125 CHECK(worker_pools_.back()); 146 CHECK(worker_pools_.back());
126 } 147 }
127 } 148 }
128 149
129 SchedulerWorkerPool* TaskSchedulerImpl::GetWorkerPoolForTraits( 150 SchedulerWorkerPool* TaskSchedulerImpl::GetWorkerPoolForTraits(
130 const TaskTraits& traits) { 151 const TaskTraits& traits) {
131 const size_t index = worker_pool_index_for_traits_callback_.Run(traits); 152 const size_t index = worker_pool_index_for_traits_callback_.Run(traits);
132 DCHECK_LT(index, worker_pools_.size()); 153 DCHECK_LT(index, worker_pools_.size());
133 return worker_pools_[index].get(); 154 return worker_pools_[index].get();
(...skipping 10 matching lines...) Expand all
144 // in |sequence|. 165 // in |sequence|.
145 const TaskTraits traits = 166 const TaskTraits traits =
146 sequence->PeekTaskTraits().WithPriority(sort_key.priority()); 167 sequence->PeekTaskTraits().WithPriority(sort_key.priority());
147 168
148 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence), 169 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
149 sort_key); 170 sort_key);
150 } 171 }
151 172
152 } // namespace internal 173 } // namespace internal
153 } // namespace base 174 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | base/task_scheduler/task_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698