Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2427853002: Revert "Inherit default text color from parent themes." (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, agrieve+watch_chromium.org, bhallam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Inherit default text color from parent themes." This reverts commit e4f0a51143b3db3643b7bac31d0be4d08642fe4e. This CL broke the text color for disabled text fields and dialog buttons. BUG=655930, 654062 TBR=dfalcantara@chromium.org Committed: https://crrev.com/563218db4ebf939eb9505e675611821c25a0d1da Cr-Commit-Position: refs/heads/master@{#425812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -21 lines) Patch
M chrome/android/java/res/layout/account_chooser_dialog_item.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/account_chooser_dialog_title.xml View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/account_signin_account_view.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/account_signin_view.xml View 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/bookmark_row_content.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/bookmark_widget_item.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/data_reduction_promo_screen.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/download_item_view.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/infobar_control_icon_with_description.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/infobar_control_message.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/infobar_control_spinner_view.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/infobar_control_toggle.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/password_entry_editor_interactive.xml View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/password_generation_popup_suggestion.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/payment_request_header.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/signin_and_sync_view.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/tab_switcher_callout.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/upgrade_activity.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java View 4 chunks +11 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Theresa
4 years, 2 months ago (2016-10-17 21:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427853002/1
4 years, 2 months ago (2016-10-17 22:53:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 23:30:07 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 23:34:01 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/563218db4ebf939eb9505e675611821c25a0d1da
Cr-Commit-Position: refs/heads/master@{#425812}

Powered by Google App Engine
This is Rietveld 408576698