Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2427823002: cros: Move system tray delegate widget container code to SystemTrayClient (Closed)

Created:
4 years, 2 months ago by James Cook
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move system tray delegate widget container code to SystemTrayClient I need this for a follow-up CL to place the Wi-Fi connect/password dialog in the correct window container for mash. Also collapse two very similar copies of code to compute the container id and use the SessionManagerClient directly to get the lock screen state, rather than tracking it via notifications. BUG=647412 TEST=none Committed: https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071 Cr-Commit-Position: refs/heads/master@{#425815}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -66 lines) Patch
M chrome/browser/ui/ash/network_connect_delegate_chromeos.cc View 1 2 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_client.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_client.cc View 1 4 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 5 chunks +4 lines, -49 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
James Cook
xiyuan, please take a look.
4 years, 2 months ago (2016-10-17 21:17:28 UTC) #5
xiyuan
lgtm
4 years, 2 months ago (2016-10-17 21:24:57 UTC) #6
James Cook
stevenjb, can I get OWNERS for c/b/ui/ash ?
4 years, 2 months ago (2016-10-17 23:22:39 UTC) #10
stevenjb
lgtm
4 years, 2 months ago (2016-10-17 23:25:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427823002/20001
4 years, 2 months ago (2016-10-17 23:29:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 23:36:59 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 23:40:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071
Cr-Commit-Position: refs/heads/master@{#425815}

Powered by Google App Engine
This is Rietveld 408576698