Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 24278007: Fix <webview> with software compositor (Closed)

Created:
7 years, 3 months ago by jbauman
Modified:
7 years, 2 months ago
Reviewers:
Fady Samuel, gab
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix <webview> with software compositor The browser plugin host should send a CompositorFrameAck for software frames during every commit, to prevent the webview's compositor from stalling out waiting for the ack before starting the next frame. BUG=295801 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225377

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 4 chunks +0 lines, -30 lines 1 comment Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.cc View 1 5 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
7 years, 3 months ago (2013-09-24 00:36:26 UTC) #1
Fady Samuel
lgtm
7 years, 3 months ago (2013-09-24 20:22:41 UTC) #2
Fady Samuel
lgtm lgtm
7 years, 3 months ago (2013-09-24 20:22:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24278007/1
7 years, 3 months ago (2013-09-24 23:52:26 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-25 01:03:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24278007/18001
7 years, 3 months ago (2013-09-25 01:50:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171593
7 years, 2 months ago (2013-09-25 03:16:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24278007/18001
7 years, 2 months ago (2013-09-26 01:16:59 UTC) #8
commit-bot: I haz the power
Change committed as 225377
7 years, 2 months ago (2013-09-26 07:24:39 UTC) #9
gab
7 years, 2 months ago (2013-09-27 13:18:05 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/24278007/diff/18001/chrome/browser/apps/web_v...
File chrome/browser/apps/web_view_browsertest.cc (right):

https://codereview.chromium.org/24278007/diff/18001/chrome/browser/apps/web_v...
chrome/browser/apps/web_view_browsertest.cc:18: #include
"content/public/browser/gpu_data_manager.h"
I think you can now remove this include too; at least it was originally added
for the checks removed below.

Powered by Google App Engine
This is Rietveld 408576698