Issue 24278004: ARM: Tweak Math.exp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24278004: ARM: Tweak Math.exp. (Closed)

Created:
7 years, 3 months ago by Rodolph Perfetta

Modified:
7 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Tweak Math.exp. Avoid corrupting the input and small assembly tuning. BUG=none TEST=test/mjsunit/lithium/MathExp.js R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16913

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -27 lines)			Patch
M	src/arm/codegen-arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 chunk	+32 lines, -19 lines	2 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/lithium/MathExp.js	View	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/24278004/diff/1/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): https://codereview.chromium.org/24278004/diff/1/src/arm/codegen-arm.cc#newcode806 src/arm/codegen-arm.cc:806: // Mov 1 in double_scratch2 as math_exp_constants_array[8] == ...

7 years, 3 months ago (2013-09-24 08:44:39 UTC) #2

Rodolph Perfetta

https://codereview.chromium.org/24278004/diff/1/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): https://codereview.chromium.org/24278004/diff/1/src/arm/codegen-arm.cc#newcode806 src/arm/codegen-arm.cc:806: // Mov 1 in double_scratch2 as math_exp_constants_array[8] == 1. ...

7 years, 3 months ago (2013-09-24 10:39:36 UTC) #3

Rodolph Perfetta

7 years, 3 months ago (2013-09-24 10:40:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16913 (presubmit successful).

Expand Messages | Collapse Messages