Remove use of "use_mirror" recipe property.

Remove use of "use_mirror" recipe property.

The "use_mirror" property is set by the recipe engine when in a
production environment to signal to the "gclient" recipe module that the SVN
GOLO mirror should be used instead of the default SVN URL. Since we're
not on SVN, this is now meaningless. It will be deprecated in recipe
engine, so remove references.

The "perf_dashboard" recipe has been using this property as a test to see if
it is running on a production system. This test has been replaced with
the identical logic that the recipe engine was using to set
"use_mirror". A build property has been added to indicate production
runs, and a note has been added to indicate that the perf dashboard bot
should explicitly specify this as a property rather than infer it from
the environment.

BUG=chromium:656741
TEST=expectations
R=iannucci@chromium.org, martiniss@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/build/+/124f02dd3006293789d17557aea29dfbb8f911e0

[martiniss, 2016-10-17 18:48:34]

lgtm

[dnj, 2016-10-17 18:50:28]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-10-17 18:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:11:23]

Description was changed from

==========
Remove use of "use_mirror" recipe property.

The "use_mirror" property is set by the recipe engine when in a
production environment to signal to the "gclient" recipe module that the SVN
GOLO mirror should be used instead of the default SVN URL. Since we're
not on SVN, this is now meaningless. It will be deprecated in recipe
engine, so remove references.

The "perf_dashboard" recipe has been using this property as a test to see if
it is running on a production system. This test has been replaced with
the identical logic that the recipe engine was using to set
"use_mirror". A build property has been added to indicate production
runs, and a note has been added to indicate that the perf dashboard bot
should explicitly specify this as a property rather than infer it from
the environment.

BUG=chromium:656741
TEST=expectations
R=iannucci@chromium.org, martiniss@chromium.org
==========

to

==========
Remove use of "use_mirror" recipe property.

The "use_mirror" property is set by the recipe engine when in a
production environment to signal to the "gclient" recipe module that the SVN
GOLO mirror should be used instead of the default SVN URL. Since we're
not on SVN, this is now meaningless. It will be deprecated in recipe
engine, so remove references.

The "perf_dashboard" recipe has been using this property as a test to see if
it is running on a production system. This test has been replaced with
the identical logic that the recipe engine was using to set
"use_mirror". A build property has been added to indicate production
runs, and a note has been added to indicate that the perf dashboard bot
should explicitly specify this as a property rather than infer it from
the environment.

BUG=chromium:656741
TEST=expectations
R=iannucci@chromium.org, martiniss@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/124f02dd3006293789d1...
==========

[commit-bot: I haz the power, 2016-10-17 19:11:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/124f02dd3006293789d1...