Don't overwrite PaymentDetails

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/JSONValuesForV8.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 205 matching lines @@
 
 void validateDisplayItems(const HeapVector<PaymentItem>& items,
                           ExceptionState& exceptionState) {
   for (const auto& item : items) {
     validateShippingOptionOrPaymentItem(item, exceptionState);
     if (exceptionState.hadException())
       return;
   }
 }
 
-void validateAndFixupShippingOptions(HeapVector<PaymentShippingOption>& options,
-                                     ExceptionState& exceptionState) {
+// Returns false if |options| should be ignored without throwing an exception.
+bool validateShippingOptions(const HeapVector<PaymentShippingOption>& options,
+                             ExceptionState& exceptionState) {
   HashSet<String> uniqueIds;
   for (const auto& option : options) {
     if (!option.hasId() || option.id().isEmpty()) {
       exceptionState.throwTypeError("ShippingOption id required");
-      return;
+      return true;
     }
 
-    if (uniqueIds.contains(option.id())) {
-      options = HeapVector<PaymentShippingOption>();
-      return;
-    }
+    if (uniqueIds.contains(option.id()))
+      return false;
+
     uniqueIds.add(option.id());
 
     validateShippingOptionOrPaymentItem(option, exceptionState);
     if (exceptionState.hadException())
-      return;
+      return true;
   }
+
+  return true;
 }
 
 void validatePaymentDetailsModifiers(
     const HeapVector<PaymentDetailsModifier>& modifiers,
     ExceptionState& exceptionState) {
   if (modifiers.isEmpty()) {
     exceptionState.throwTypeError(
         "Must specify at least one payment details modifier");
     return;
   }
@@ skipping 28 matching lines @@
     }
 
     if (modifier.hasAdditionalDisplayItems()) {
       validateDisplayItems(modifier.additionalDisplayItems(), exceptionState);
       if (exceptionState.hadException())
         return;
     }
   }
 }
 
-void validateAndFixupPaymentDetails(PaymentDetails& details,
-                                    ExceptionState& exceptionState) {
+// Returns false if the shipping options should be ignored without throwing an
+// exception.

[Mathieu, 2016/10/18 14:13:00]

It took me a few passes to understand this pattern. Perhaps you could expand on
the comment here or at the callsite. Also it's a bit jarring to see exceptions
being thrown and "return true;" right after, but I understand the need... 

[please use gerrit instead, 2016/10/19 15:44:34]

Done.

+bool validatePaymentDetails(const PaymentDetails& details,
+                            ExceptionState& exceptionState) {
   if (!details.hasTotal()) {
     exceptionState.throwTypeError("Must specify total");
-    return;
+    return true;
   }
 
   validateShippingOptionOrPaymentItem(details.total(), exceptionState);
   if (exceptionState.hadException())
-    return;
+    return true;
 
   if (details.total().amount().value()[0] == '-') {
     exceptionState.throwTypeError("Total amount value should be non-negative");
-    return;
+    return true;
   }
 
   if (details.hasDisplayItems()) {
     validateDisplayItems(details.displayItems(), exceptionState);
     if (exceptionState.hadException())
-      return;
+      return true;
   }
 
   if (details.hasShippingOptions()) {
-    HeapVector<PaymentShippingOption> fixedShippingOptions =
-        details.shippingOptions();
-    validateAndFixupShippingOptions(fixedShippingOptions, exceptionState);
-    details.setShippingOptions(fixedShippingOptions);
+    if (!validateShippingOptions(details.shippingOptions(), exceptionState))
+      return false;
+
     if (exceptionState.hadException())
-      return;
+      return true;
   }
 
   if (details.hasModifiers()) {
     validatePaymentDetailsModifiers(details.modifiers(), exceptionState);
   }
 
   String errorMessage;
   if (!PaymentsValidators::isValidErrorMsgFormat(details.error(),
                                                  &errorMessage)) {
     exceptionState.throwTypeError(errorMessage);
-    return;
   }
+
+  return true;
 }
 
 void validateAndConvertPaymentMethodData(
     const HeapVector<PaymentMethodData>& paymentMethodData,
     Vector<PaymentRequest::MethodData>* methodData,
     ExceptionState& exceptionState) {
   if (paymentMethodData.isEmpty()) {
     exceptionState.throwTypeError(
         "Must specify at least one payment method identifier");
     return;
@@ skipping 58 matching lines @@
   static const char* const validValues[] = {
       "shipping", "delivery", "pickup",
   };
   for (size_t i = 0; i < WTF_ARRAY_LENGTH(validValues); i++) {
     if (shippingType == validValues[i])
       return shippingType;
   }
   return validValues[0];
 }
 
+mojom::blink::PaymentDetailsPtr maybeKeepShippingOptions(
+    mojom::blink::PaymentDetailsPtr details,
+    bool keep) {
+  if (!keep)
+    details->shipping_options.resize(0);
+
+  return details;
+}
+
 }  // namespace
 
 PaymentRequest* PaymentRequest::create(
     ScriptState* scriptState,
     const HeapVector<PaymentMethodData>& methodData,
     const PaymentDetails& details,
     ExceptionState& exceptionState) {
   return new PaymentRequest(scriptState, methodData, details, PaymentOptions(),
                             exceptionState);
 }
@@ skipping 97 matching lines @@
   V8PaymentDetails::toImpl(detailsScriptValue.isolate(),
                            detailsScriptValue.v8Value(), details,
                            exceptionState);
   if (exceptionState.hadException()) {
     m_showResolver->reject(
         DOMException::create(SyntaxError, exceptionState.message()));
     clearResolversAndCloseMojoConnection();
     return;
   }
 
-  validateAndFixupPaymentDetails(details, exceptionState);
+  bool keepShippingOptions = validatePaymentDetails(details, exceptionState);
   if (exceptionState.hadException()) {
     m_showResolver->reject(
         DOMException::create(SyntaxError, exceptionState.message()));
     clearResolversAndCloseMojoConnection();
     return;
   }
 
-  if (m_options.requestShipping())
-    m_shippingOption = getSelectedShippingOption(details);
+  if (m_options.requestShipping()) {
+    if (keepShippingOptions)
+      m_shippingOption = getSelectedShippingOption(details);
+    else
+      m_shippingOption = String();
+  }
 
-  m_paymentProvider->UpdateWith(mojom::blink::PaymentDetails::From(details));
+  m_paymentProvider->UpdateWith(maybeKeepShippingOptions(
+      mojom::blink::PaymentDetails::From(details), keepShippingOptions));
 }
 
 void PaymentRequest::onUpdatePaymentDetailsFailure(const String& error) {
   if (m_showResolver)
     m_showResolver->reject(DOMException::create(AbortError, error));
   if (m_completeResolver)
     m_completeResolver->reject(DOMException::create(AbortError, error));
   clearResolversAndCloseMojoConnection();
 }
 
@@ skipping 33 matching lines @@
     return;
   }
 
   if (!scriptState->domWindow()->frame() ||
       !scriptState->domWindow()->frame()->isMainFrame()) {
     exceptionState.throwSecurityError(
         "Must be in a top-level browsing context");
     return;
   }
 
-  PaymentDetails fixedDetails(details);
-  validateAndFixupPaymentDetails(fixedDetails, exceptionState);
+  bool keepShippingOptions = validatePaymentDetails(details, exceptionState);
   if (exceptionState.hadException())
     return;
 
-  if (fixedDetails.hasError() && !fixedDetails.error().isEmpty()) {
+  if (details.hasError() && !details.error().isEmpty()) {
     exceptionState.throwTypeError("Error value should be empty");
     return;
   }
 
   if (m_options.requestShipping()) {
-    m_shippingOption = getSelectedShippingOption(fixedDetails);
+    if (keepShippingOptions)
+      m_shippingOption = getSelectedShippingOption(details);
     m_shippingType = getValidShippingType(m_options.shippingType());
   }
 
   scriptState->domWindow()->frame()->interfaceProvider()->getInterface(
       mojo::GetProxy(&m_paymentProvider));
   m_paymentProvider.set_connection_error_handler(convertToBaseCallback(
       WTF::bind(&PaymentRequest::OnError, wrapWeakPersistent(this),
                 mojom::blink::PaymentErrorReason::UNKNOWN)));
   m_paymentProvider->Init(
       m_clientBinding.CreateInterfacePtrAndBind(),
       mojo::WTFArray<mojom::blink::PaymentMethodDataPtr>::From(
           validatedMethodData),
-      mojom::blink::PaymentDetails::From(fixedDetails),
+      maybeKeepShippingOptions(mojom::blink::PaymentDetails::From(details),
+                               keepShippingOptions),
       mojom::blink::PaymentOptions::From(m_options));
 }
 
 void PaymentRequest::contextDestroyed() {
   clearResolversAndCloseMojoConnection();
 }
 
 void PaymentRequest::OnShippingAddressChange(
     mojom::blink::PaymentAddressPtr address) {
   DCHECK(m_showResolver);
@@ skipping 157 matching lines @@
   m_completeTimer.stop();
   m_completeResolver.clear();
   m_showResolver.clear();
   m_abortResolver.clear();
   if (m_clientBinding.is_bound())
     m_clientBinding.Close();
   m_paymentProvider.reset();
 }
 
 }  // namespace blink