Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2427633002: Revert of [debug] Consistently use script from FrameMirror (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debug] Consistently use script from FrameMirror (patchset #3 id:40001 of https://codereview.chromium.org/2415073003/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10706 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [debug] Consistently use script from FrameMirror > > ... instead of getting it from the FunctionMirror. For WASM frames > (including asm.js -> WASM), the function is either unresolved or does > not contain the script. > > The added test case failed before this CL. > > R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org > BUG=v8:4203 > > Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615 > Cr-Commit-Position: refs/heads/master@{#40348} TBR=kozyatinskiy@chromium.org,yangguo@chromium.org,titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Committed: https://crrev.com/f5d333c2975ca6f36413f1cd62cdd08ff5810404 Cr-Commit-Position: refs/heads/master@{#40362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -125 lines) Patch
M src/debug/mirrors.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/debugger-script.js View 5 chunks +7 lines, -19 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 3 chunks +1 line, -7 lines 0 comments Download
D test/inspector/debugger/asm-js-stack.js View 1 chunk +0 lines, -79 lines 0 comments Download
D test/inspector/debugger/asm-js-stack-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [debug] Consistently use script from FrameMirror
4 years, 2 months ago (2016-10-17 12:37:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427633002/1
4 years, 2 months ago (2016-10-17 12:37:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 12:38:04 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 12:38:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d333c2975ca6f36413f1cd62cdd08ff5810404
Cr-Commit-Position: refs/heads/master@{#40362}

Powered by Google App Engine
This is Rietveld 408576698