Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2427623002: Fix OOM handling on a background thread. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix OOM handling on a background thread. We don't have an Isolate, so we cannot use it for retrieving data or calling the embedder's OOM handler. So just crash. BUG=5525 Committed: https://crrev.com/d293bf54b0c9665931c7c6e84591e35d5c09a083 Cr-Commit-Position: refs/heads/master@{#40363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/api.cc View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
marja
ptal
4 years, 2 months ago (2016-10-17 12:33:43 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 12:43:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427623002/1
4 years, 2 months ago (2016-10-17 12:45:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 13:01:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 13:01:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d293bf54b0c9665931c7c6e84591e35d5c09a083
Cr-Commit-Position: refs/heads/master@{#40363}

Powered by Google App Engine
This is Rietveld 408576698