Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2427613004: Add initial RandomOrderExpectations file (Closed)

Created:
4 years, 2 months ago by jeffcarp
Modified:
4 years, 1 month ago
Reviewers:
qyearsley, mithro
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Here's a first shot at getting random order runs green locally, by adding a RandomOrderExpectations file. Run by adding: --additional-expectations=LayoutTests/RandomOrderExpectations 5 out of 5 local runs have passed with this file (minus 2 tests which I think might be a regression: https://crbug.com/656777). BUG=601332 Committed: https://crrev.com/62121cde5cfb54d37231f0dc271d06ef8a237853 Cr-Commit-Position: refs/heads/master@{#428168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/RandomOrderExpectations View 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jeffcarp
4 years, 2 months ago (2016-10-17 22:27:33 UTC) #3
mithro
On 2016/10/17 22:27:33, jeffcarp wrote: LGTM. Shall we land it?
4 years, 1 month ago (2016-10-27 00:30:03 UTC) #4
jeffcarp
On 2016/10/27 at 00:30:03, tansell wrote: > On 2016/10/17 22:27:33, jeffcarp wrote: > > LGTM. ...
4 years, 1 month ago (2016-10-27 20:23:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427613004/1
4 years, 1 month ago (2016-10-27 20:24:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 22:43:01 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:45:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62121cde5cfb54d37231f0dc271d06ef8a237853
Cr-Commit-Position: refs/heads/master@{#428168}

Powered by Google App Engine
This is Rietveld 408576698