pkg/scheduled_test/test/descriptor/pattern_test.dart - Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/test/descriptor/pattern_test.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove checks and comments on type of exception thrown. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/scheduled_test/test/descriptor/async_test.dart ('K') | « pkg/scheduled_test/test/descriptor/nothing_test.dart ('k') | pkg/scheduled_test/test/scheduled_process_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/scheduled_test/test/descriptor/pattern_test.dart

diff --git a/pkg/scheduled_test/test/descriptor/pattern_test.dart b/pkg/scheduled_test/test/descriptor/pattern_test.dart

index 7bd33a37283d90225b4f29fde2856610f5812082..97249efdcc0a68d9842e4f3e31511fbe3186de91 100644

--- a/pkg/scheduled_test/test/descriptor/pattern_test.dart

+++ b/pkg/scheduled_test/test/descriptor/pattern_test.dart

@@ -68,7 +68,7 @@ void main() {

test('test 2', () {

expect(errors, everyElement(new isInstanceOf<ScheduleError>()));

expect(errors.length, equals(1));

- expect(errors.first.error,

+ expect(errors.first.error.toString(),

matches(r"^No entry found in '[^']+' matching /f\.\./\.$"));

});

}, passing: ['test 2']);

@@ -90,7 +90,7 @@ void main() {

test('test 2', () {

expect(errors, everyElement(new isInstanceOf<ScheduleError>()));

expect(errors.length, equals(1));

- expect(errors.first.error,

+ expect(errors.first.error.toString(),

matches(r"^Caught error\n"

r"| File 'foo' should contain:\n"

r"| | bar\n"

@@ -123,7 +123,7 @@ void main() {

test('test 2', () {

expect(errors, everyElement(new isInstanceOf<ScheduleError>()));

expect(errors.length, equals(1));

- expect(errors.first.error,

+ expect(errors.first.error.toString(),

matches(r"^Caught error\n"

r"| File 'bar' should contain:\n"

r"| | baz\n"

@@ -154,7 +154,7 @@ void main() {

test('test 2', () {

expect(errors, everyElement(new isInstanceOf<ScheduleError>()));

expect(errors.length, equals(1));

- expect(errors.first.error, matches(

+ expect(errors.first.error.toString(), matches(

r"^Multiple valid entries found in '[^']+' matching "

r"\/f\.\./:\n"

r"\* faa\n"