Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/scheduled_test/test/descriptor/async_test.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove checks and comments on type of exception thrown. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/descriptor/async_test.dart
diff --git a/pkg/scheduled_test/test/descriptor/async_test.dart b/pkg/scheduled_test/test/descriptor/async_test.dart
index b4fde985b93c34be5d57d71f44aad2f13700a903..b93721de0ab049b7d6d96929db6d77e25840a942 100644
--- a/pkg/scheduled_test/test/descriptor/async_test.dart
+++ b/pkg/scheduled_test/test/descriptor/async_test.dart
@@ -72,8 +72,8 @@ void main() {
test('test 2', () {
expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
expect(errors.length, equals(1));
- expect(errors.first.error,
- matches(r"^File not found: '[^']+[\\/]name\.txt'\.$"));
+ expect(errors.first.error.toString(),
+ matches(r"^File not found: '[^']+[\\/]name\.txt'\.$"));
});
Bill Hesse 2013/09/23 17:15:25 Should we even just drop the length check, and wri
nweiz 2013/09/23 22:14:34 I like this idea (probably with two checks rather
}, passing: ['test 2']);
@@ -115,7 +115,7 @@ void main() {
test('test 2', () {
expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
expect(errors.length, equals(1));
- expect(errors.first.error,
+ expect(errors.first.error.toString(),
matches(r"^Directory not found: '[^']+[\\/]dir'\.$"));
});
}, passing: ['test 2']);
« no previous file with comments | « pkg/scheduled_test/lib/src/descriptor/pattern_descriptor.dart ('k') | pkg/scheduled_test/test/descriptor/directory_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698