pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart - Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove checks and comments on type of exception thrown. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart ('k') | pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart » ('j') | pkg/scheduled_test/test/descriptor/async_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

diff --git a/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart b/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

index eca863ae772dadbe669266d36fe3715e57f422b3..9111b3dd656824a6a479bfd1610d70727fe21d7b 100644

--- a/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

+++ b/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

@@ -59,7 +59,7 @@ abstract class FileDescriptor extends Descriptor implements ReadableDescriptor {

if (parent == null) parent = defaultRoot;

var fullPath = path.join(parent, name);

if (!new File(fullPath).existsSync()) {

- throw "File not found: '$fullPath'.";

+ fail("File not found: '$fullPath'.");

}

return new File(fullPath).readAsBytes().then(_validateNow);

@@ -84,7 +84,7 @@ class _BinaryFileDescriptor extends FileDescriptor {

Future _validateNow(List<int> actualContents) {

if (orderedIterableEquals(contents, actualContents)) return null;

// TODO(nweiz): show a hex dump here if the data is small enough.

- throw "File '$name' didn't contain the expected binary data.";

+ fail("File '$name' didn't contain the expected binary data.");

}