Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: pkg/scheduled_test/test/descriptor/file_test.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Also in async_test.dart Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/descriptor/file_test.dart
diff --git a/pkg/scheduled_test/test/descriptor/file_test.dart b/pkg/scheduled_test/test/descriptor/file_test.dart
index e22a9929fab4870831141dbb64bf5b31f490e954..0b2a90fd8386e533bd0cc20f3bfe8c0d42596e65 100644
--- a/pkg/scheduled_test/test/descriptor/file_test.dart
+++ b/pkg/scheduled_test/test/descriptor/file_test.dart
@@ -75,13 +75,12 @@ void main() {
});
test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals([
- "File 'name.txt' should contain:\n"
- "| contents\n"
- "but actually contained:\n"
- "X wrongtents"
- ]), verbose: true);
+ expect(errors.single, new isInstanceOf<ScheduleError>());
+ expect(errors.single.error.toString(), equals(
+ "File 'name.txt' should contain:\n"
+ "| contents\n"
+ "but actually contained:\n"
+ "X wrongtents"));
});
}, passing: ['test 2']);
@@ -98,9 +97,8 @@ void main() {
});
test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.length, equals(1));
- expect(errors.first.error,
+ expect(errors.single, new isInstanceOf<ScheduleError>());
+ expect(errors.single.error.toString(),
matches(r"^File not found: '[^']+[\\/]name\.txt'\.$"));
});
}, passing: ['test 2']);
@@ -165,10 +163,9 @@ void main() {
});
test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals([
- "File 'name.bin' didn't contain the expected binary data."
- ]), verbose: true);
+ expect(errors.single, new isInstanceOf<ScheduleError>());
+ expect(errors.single.error.toString(), equals(
+ "File 'name.bin' didn't contain the expected binary data."));
});
}, passing: ['test 2']);
@@ -218,11 +215,10 @@ void main() {
});
test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error.message), equals([
- "Expected: contains 'baaz'\n"
- " Actual: 'barfoobaz'\n"
- ]), verbose: true);
+ expect(errors.single, new isInstanceOf<ScheduleError>());
+ expect(errors.single.error.toString(), equals(
+ "Expected: contains 'baaz'\n"
+ " Actual: 'barfoobaz'\n"));
});
}, passing: ['test 2']);
@@ -259,11 +255,10 @@ void main() {
});
test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error.message), equals([
- "Expected: contains <12>\n"
- " Actual: [98, 97, 114, 102, 111, 111, 98, 97, 122]\n"
- ]), verbose: true);
+ expect(errors.single, new isInstanceOf<ScheduleError>());
+ expect(errors.single.error.toString(), equals(
+ "Expected: contains <12>\n"
+ " Actual: [98, 97, 114, 102, 111, 111, 98, 97, 122]\n"));
});
}, passing: ['test 2']);
}
« no previous file with comments | « pkg/scheduled_test/test/descriptor/directory_test.dart ('k') | pkg/scheduled_test/test/descriptor/nothing_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698